Repository navigation
Move context-filtering completion tests to the end-to-end tier - #719
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #719 +/- ##
============================================
+ Coverage 82.71% 82.75% +0.04%
Complexity 1901 1901
============================================
Files 135 135
Lines 4876 4876
============================================
+ Hits 4033 4035 +2
+ Misses 843 841 -2 ☔ View full report in Codecov by Harness. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Firehed
marked this pull request as ready for review
October 7, 2026 20:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the context-filtering completion tests out of
CompletionHandlerIntegrationTestintocompletion-context-filtering.php: a comment, member access in a comment, a heredoc (variables only), and the position after a finished statement.Part of #694.
Unit tests.
CompositeCompletionSourceTestnow covers the composite's early returns and itsNoneclassification:ContextDetectorTestandCompletionClassifierTestalready own which positions are comments, strings, heredocs, or unclassified.Script. The finished-statement case types
();after an existing marker rather than opening inline PHP. The plain-comment case's fixture has no word before the cursor, so it would answer nothing even without the early return; member access in a comment is the case that needs it.A moved position. The deleted "unknown context" test put its cursor before the
;of$x = 1;, where the prefix is1. Its name says after the statement, so both replacements put the cursor there.Coverage.
CompositeCompletionSourceis now fully covered by its own unit test.🤖 Generated with Claude Code