Repository navigation
Move response cap completion tests to the end-to-end tier - #718
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #718 +/- ##
============================================
+ Coverage 82.52% 82.71% +0.18%
Complexity 1901 1901
============================================
Files 135 135
Lines 4876 4876
============================================
+ Hits 4024 4033 +9
+ Misses 852 843 -9 ☔ View full report in Codecov by Harness. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the response cap tests to the end-to-end tier and merges
CompletionCapFloodTestinto it.Part of #694.
Script.
completion-response-cap.phpcompletes the prefixsinsidenamespace Fixtures\Completion(new fixturesrc/Completion/ResponseCap.php). Core PHP'ss*functions overflow the cap, so the list is reported incomplete. The file's ownsummarizeTotalsstill survives: it ranks as a current-namespace symbol, while by name well over 100 core functions (str*,stream_*,sprintf, …) sort before it. Sorting the cap by label alone makes the script fail. This is the flood test's point with real data instead of a generated classmap, and it needs no optional extension.The flood test also covered built-in functions beating workspace classes in global and call contexts. Those pieces stay unit-tested (
ReferenceKindTestorders the kinds,ReferenceResolverTestassigns them,SymbolCandidatesTestwrites the prefix), and every context reaches the prefix through the sameSymbolCandidates::find.Unit tests.
ReferenceKindTestis new. The unit suite did not coverReferenceKind::priority(), the ranking that decides which symbols survive the cap. It pins the order and that no two kinds tie.CompletionHandlerTestalready covers the cap itself: untouched under the limit, sorted bysortText ?? label, truncated, and flagged incomplete over it.New vocabulary.
ReportsIncomplete()checks the list'sisIncompleteflag.Removed.
CompletionHandlerIntegrationTest, and the setup they alone needed (a seeding helper and a handler factory taking its own source).CompletionCapFloodTest.flood()method ofNamespacing/AbsoluteNavigation.php, whose marker only the deleted navigation cap test used.Coverage.
ReferenceKindandCompletionHandlerare fully covered by their own unit tests.🤖 Generated with Claude Code