Support for tablespaces by Zhdanov0 · Pull Request #8314 · FirebirdSQL/firebird

Zhdanov0 · 2024-11-12T09:43:34Z

Link to proposal: https://groups.google.com/g/firebird-devel/c/geF0A2_kC28

…ird_tablespaces

only file deleting is left at post DFW stage. Added missed object type of TABLESPACES. Added security class for tablespaces which allows not to skip check of the privileges. Corrected page space before fetching of the root index page.

…code as for deleting a table. NOTE: Now we fire DDL trigger for deleling tables even if they are deleting as result of DROP TABLESPACE ... INCLUDING CONTENTS

…nt of usage have the page space in the pace space manager. Also the same behaviour has been ported to the expression index handling.

…e id

The recent change added a couple of new fields into CreationIndex which were not initialized before fast loading while index moving.

…RELATION_ID is NULL in that case

…g, adding and deleting page spaces

…espace creation Page space should be added into pageSpaces array after creating/opening of tablespace file to prevent other attachments from getting incomplete page space.

…ME> INCLUDING CONTENTS. Deleting from tablespaces cache is implemented.

…e rollback work correctly. The file will be created at DFW stage

…odes

…opped in the same transaction

… A relation may already be deleted by dfw_delete_relation in the same transaction

It allows to determine if there are attachments that use a tablespace (and have its page space opened) when another attachment needs the EX lock on that tablespace (for example, to execute ALTER TABLESPACE).

… make it work correctly

…file containing an index is unsuccessful

…rash while trying to write dirty pages of closed tablespace to disk

…ropped in the same transaction

…tion

Cool-Hunter · 2026-08-17T06:57:01Z

+    ALTER INDEX ...
+    [SET TABLESPACE [TO] {<TS NAME> | PRIMARY}]
+
+    The index data will be moved to the specified tablespace or to the main database.


May be to add about necessary locks for the index movement.

Locks are documented now

Cool-Hunter · 2026-08-17T06:57:48Z

+
+    ALTER TABLE <TABLE NAME> SET TABLESPACE [TO] {<TS NAME> | PRIMARY}
+
+    The table data will be moved to the specified tablespace or to the main database.


May be add about necessary locks for the table's data movement

Locks are documented now

Cool-Hunter · 2026-08-17T07:03:16Z

+    If you do not specify the above options, when restoring a database that has tablespaces,
+    an error about the inability to determine the path to restore tablespaces will occur.
+
+    3. Show


is it a command of isql?

Cool-Hunter · 2026-08-17T07:06:55Z

+   - allocate necessary number of pointer pages by extents.
+   - allocate the rest of pointer pages by pages.
+   - walking through PPs allocate DPs by pages or extents.
+   - fix every PP by correcting DP numbers and ppg_next pointer and build a map


still allocate new data pages on demand for data pages with "orphan" flags which are not in the PP.

Cool-Hunter · 2026-08-29T07:43:35Z

 	return status->getState() & IStatus::STATE_ERRORS ? true : false;
 }

+static bool drop_files(ObjectsArray<PathName>& tsFiles)


Just "files" is better than "tsFiles".

Fixed and slightly refactored to simplify the code even more.

Cool-Hunter · 2026-08-29T08:09:43Z

 			}
 		}

+		ULONG pageSpaceId = DB_PAGE_SPACE;


The same code as above. New function or lambda?

Removed the redundancy

Cool-Hunter · 2026-08-29T08:29:41Z

+		MetaName name;
+
+		if (pageSpaceId == 0)
+			name = TEMP_TABLESPACE_NAME;


Maybe to move the logic under Tablespace::lookup?

Cool-Hunter · 2026-08-30T09:25:26Z

+			Tablespace* get(ULONG id);
+			Tablespace* get(const MetaName& name);
+
+			void store(Tablespace* tabpeSpace);


Cool-Hunter · 2026-08-30T09:28:25Z

+			Firebird::Mutex m_mutex;
+		};
+
+		explicit Tablespace(MemoryPool& pool, ULONG id = DB_PAGE_SPACE)


There is no backward compatibility, so maybe better not to use default value for id?

Replaced with an explicit ID passed (only a single place is affected)

Cool-Hunter · 2026-08-30T10:21:23Z

+
+		if (tableSpace.hasData() && applyTablespacesDdl(tdbb))
+		{
+			if ((tableSpace != PRIMARY_TABLESPACE_NAME) &&


Here and later Is this check is necessary? AFAIU checkObjectExist takes into account special case that tablespace is PRIMARY.

Simplified and made consistent with the handling of other object types.

…w tablespace. Some misc corrections.

…lespaces2

…rrections. Remove the redundant code.

dyemanov · 2026-09-17T08:23:02Z

I've addressed most of the review comments, a few are still in the pipeline and will be finished this week.

… pagespace iteration in the validation code. More explicit pagespace ID range handling.

…view cleanup

…lespaces2

dyemanov · 2026-09-21T07:42:03Z

For gstat, we have also added a -ts switch that allows to analyze only particular tablespace. It will be added as a separate PR (unless you think it's not needed for Firebird).

hvlad · 2026-09-21T15:42:15Z

+
+    4. Replication
+    There is an apply_tablespaces_ddl parameter for replication, it may be configured for the replica side.
+    If this parameter is disabled, CREATE/ALTER/DROP TSABLESPACE statements will not be ignored on the replica and


will not be ignored ?

romansimakov and others added 30 commits January 9, 2021 20:56

Port of TABLESPACES implementation from RedDatabase

de87348

Merge remote-tracking branch 'origin/firebird_master' into port2fireb…

1c5d6fe

…ird_tablespaces

Avoid deleting an index tree if it does not exist

766fc1b

Wrong constant for the object.

1cf0b81

Now to delete the tables while deleting a tablespace we use the same …

6598a01

…code as for deleting a table. NOTE: Now we fire DDL trigger for deleling tables even if they are deleting as result of DROP TABLESPACE ... INCLUDING CONTENTS

Now we get tablespace before operations on index data and by the mome…

390547a

…nt of usage have the page space in the pace space manager. Also the same behaviour has been ported to the expression index handling.

Added looking up tablespace in BTR_description after reading pagespac…

5eeaddd

…e id

Corrupted index after altering its tablespace

bb73db9

The recent change added a couple of new fields into CreationIndex which were not initialized before fast loading while index moving.

Do not allow ALTER TABLESPACE for tables which are not commited. RDB$…

30b58c4

…RELATION_ID is NULL in that case

Remove wrong line which was added accidentally during merge

9bb1f42

Fix race condition when several attachments are simultaneously findin…

f8c52a8

…g, adding and deleting page spaces

Remove assertion which is wrong because pageSpace is NULL during tabl…

09b9ae7

…espace creation Page space should be added into pageSpaces array after creating/opening of tablespace file to prevent other attachments from getting incomplete page space.

Fix closing and deletion of tablespace file after DROP TABLESPACE <NA…

83630ed

…ME> INCLUDING CONTENTS. Deleting from tablespaces cache is implemented.

Do not create tablespace file immediately at CREATE TABLESPACE to mak…

e2929aa

…e rollback work correctly. The file will be created at DFW stage

Post dfw_drop_tablespace before trigger execution like in other DDL n…

f44a17d

…odes

Do not allow to ALTER TABLESPACE for a table if the tablespace was dr…

89b2dc2

…opped in the same transaction

Fix crash by checking existence of a relation at dfw_clear_datapages.…

d2cdd8e

… A relation may already be deleted by dfw_delete_relation in the same transaction

Print ID of a missing tablespace in the error message

70469e6

Get the SR lock for a tablespace when putting it into tablespaces cache

9f1aa54

It allows to determine if there are attachments that use a tablespace (and have its page space opened) when another attachment needs the EX lock on that tablespace (for example, to execute ALTER TABLESPACE).

Do not try to find a tablespace during ALTER TABLE DROP TABLESPACE to…

b709ae1

… make it work correctly

Avoid assertion failure in ~thread_db() when opening of a tablespace …

ca7a668

…file containing an index is unsuccessful

Flush DB pages before closing a tablespace file. It prevents server c…

72a92fb

…rash while trying to write dirty pages of closed tablespace to disk

Do not allow to ALTER TABLESPACE for an index if the tablespace was d…

df16a6e

…ropped in the same transaction

Do not move index pages when the index is deleted in the same transac…

c8c9876

…tion

Fix build

936f2dd

Merge branch 'firebird_master' into port2firebird_tablespaces

4e66b10

Add ability to ALTER TABLESPACE for tables which are not committed

7426dac

Fix DROP TABLE for tables which are not committed

75d81b3

Add some useful assertions for SR lock of tablespace

b8ef3d5

Fix the typo and add comment

917660b

Cool-Hunter reviewed Sep 6, 2026

View reviewed changes

dyemanov added 17 commits September 7, 2026 15:43

Simplify the code a bit

d704468

Some cleanup and minor adjustments based on reviews

c58767b

Avoid code duplication

aa3e4bd

Simplify the code and fix minor inconsistencies

0b9d80b

Fix my mistake in the recent commit

e921155

Cleanup the unrelated files

dbc926a

Cleanup not implemented code

8a4483f

Fix some issues with SharedReadVector

5d8c2d9

Document CREATE OR ALTER TABLESPACE

630b0e6

Fix copying large fragment data pages (not accounted in PP) to the ne…

deb6b48

…w tablespace. Some misc corrections.

Merge remote-tracking branch 'firebird/master' into port2firebird_tab…

e1135db

…lespaces2

Fix the assert condition

0527390

Code simplification and better comments

3cfff14

Potfixes for local/packaged temporary tables

6c004f0

Merge remote-tracking branch 'firebird/master' into port2firebird_tab…

2ef7734

…lespaces2

Fix code weirdness after prior copy-pasting. Misc naming/constness co…

fd37758

…rrections. Remove the redundant code.

Document transitions for the irt_migrate state

9f601fb

dyemanov added 8 commits September 18, 2026 08:17

Better naming and comments for tablespace flags

b01e478

Move generated ID 'shifting' from VIO to INI. Add comments. Optimized…

dc1b706

… pagespace iteration in the validation code. More explicit pagespace ID range handling.

Make the naming more consistent

40ac1c3

Separate PageNumber to be usable from ods.h, more assertions, post-re…

0f5f6cf

…view cleanup

More renaming, cleanup and comments after review

992873d

Take also a GC-lock while copying pages

b4a38ec

Merge remote-tracking branch 'firebird/master' into port2firebird_tab…

6e9a1a6

…lespaces2

Tablespace support for GSTAT

337099f

hvlad reviewed Sep 21, 2026

View reviewed changes


		ALTER TABLE <TABLE NAME> SET TABLESPACE [TO] {<TS NAME> \| PRIMARY}

		The table data will be moved to the specified tablespace or to the main database.

Uh oh!

Conversation

Zhdanov0 commented Nov 12, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dyemanov Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dyemanov commented Sep 17, 2026

Uh oh!

dyemanov commented Sep 21, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

dyemanov Sep 17, 2026 •

edited

Loading