Repository navigation
Conversation
RozmiDan
reviewed
Nov 11, 2026
Comment on lines
+684
to
+686
| ErrPrimary = errors.New("not replica") | ||
| // ErrReplica is returned when a primary connection is required but the connection is replica. | ||
| ErrReplica = errors.New("not primary") |
Contributor
There was a problem hiding this comment.
Seems more consistent to use ErrPrimaryConnection and ErrReplicaConnection here. This follows public naming pattern and matches ErrReadOnlyConnection and ErrReadWriteConnection above.
| require.ErrorIs(t, err, ErrConnClosed) | ||
| } | ||
|
|
||
| func TestConnectWithValidateConnectSessionAttributeErrors(t *testing.T) { |
Contributor
There was a problem hiding this comment.
I'm not sure what this test is intended to verify. It opens a real connection, but the callback returns each sentinel directly, so none of the actual target_session_attrs validators are exercised. The read-only/read-write paths are already covered in fbconn_test.go, while the message and NotPreferredError checks can be unit tests without a database.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.