Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,27 @@ jobs:
./reactfire-${{ github.run_id }}/unpack.sh
- name: Run tests
run: npm run test
type-check:
runs-on: ubuntu-latest
strategy:
matrix:
react: ["18", "19"]
fail-fast: false
name: Type check (React ${{ matrix.react }})
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Setup node
uses: actions/setup-node@v4
with:
node-version: '24'
cache: 'npm'
- name: Install deps
run: npm ci
- name: Install React ${{ matrix.react }} types
run: npm install --no-save react@${{ matrix.react }} react-dom@${{ matrix.react }} @types/react@${{ matrix.react }} @types/react-dom@${{ matrix.react }}
- name: Type check
run: npx tsc --noEmit
publish:
runs-on: ubuntu-latest
name: Publish (NPM)
Expand Down
4 changes: 2 additions & 2 deletions docs/reference/functions/AuthCheck.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions docs/reference/functions/SuspenseWithPerf.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/type-aliases/StorageImageProps.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions docs/reference/variables/AnalyticsProvider.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions docs/reference/variables/AppCheckProvider.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions docs/reference/variables/AuthProvider.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions docs/reference/variables/DatabaseProvider.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions docs/reference/variables/FirestoreProvider.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions docs/reference/variables/FunctionsProvider.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions docs/reference/variables/PerformanceProvider.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions docs/reference/variables/RemoteConfigProvider.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions docs/reference/variables/StorageProvider.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/auth.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ export function ClaimsCheck({ user, fallback, children, requiredClaims }: Claims
*
* Meant for Concurrent mode only (`<FirebaseAppProvider suspense=true />`). [More detail](https://github.com/FirebaseExtended/reactfire/issues/325#issuecomment-827654376).
*/
export function AuthCheck({ fallback, children, requiredClaims }: AuthCheckProps): JSX.Element {
export function AuthCheck({ fallback, children, requiredClaims }: AuthCheckProps): React.ReactElement {
const { data: user } = useUser<User>();

const suspenseMode = useSuspenseEnabledFromConfigAndContext();
Expand Down
2 changes: 1 addition & 1 deletion src/performance.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export interface SuspensePerfProps {
fallback: React.ReactNode;
}

export function SuspenseWithPerf({ children, traceId, fallback }: SuspensePerfProps): JSX.Element {
export function SuspenseWithPerf({ children, traceId, fallback }: SuspensePerfProps): React.ReactElement {
// TODO: Should this import firebase/performance?

const perf = typeof globalThis !== 'undefined' ? globalThis.performance : undefined;
Expand Down
2 changes: 1 addition & 1 deletion src/sdk.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export const RemoteConfigSdkContext = React.createContext<RemoteConfig | undefin
type FirebaseSdks = Analytics | AppCheck | Auth | Database | Firestore | FirebasePerformance | FirebaseStorage | Functions | RemoteConfig;

function getSdkProvider<Sdk extends FirebaseSdks>(SdkContext: React.Context<Sdk | undefined>) {
return function SdkProvider(props: React.PropsWithChildren<{ sdk: Sdk }>) {
return function SdkProvider(props: React.PropsWithChildren<{ sdk: Sdk }>): React.ReactElement {
if (!props.sdk) throw new Error('no sdk provided');

const contextualAppName = useFirebaseApp().name;
Expand Down
4 changes: 2 additions & 2 deletions src/storage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export type StorageImageProps = {
storagePath: string;
storage?: FirebaseStorage;
suspense?: boolean;
placeHolder?: JSX.Element;
placeHolder?: React.ReactNode;
};

function StorageFromContext(props: StorageImageProps & React.DetailedHTMLProps<React.ImgHTMLAttributes<HTMLImageElement>, HTMLImageElement>) {
Expand All @@ -48,7 +48,7 @@ function StorageFromContext(props: StorageImageProps & React.DetailedHTMLProps<R
return <INTERNALStorageImage {...props} />;
}

function INTERNALStorageImage(props: StorageImageProps & React.DetailedHTMLProps<React.ImgHTMLAttributes<HTMLImageElement>, HTMLImageElement>): JSX.Element {
function INTERNALStorageImage(props: StorageImageProps & React.DetailedHTMLProps<React.ImgHTMLAttributes<HTMLImageElement>, HTMLImageElement>): React.ReactNode {
const { storage, storagePath, suspense, placeHolder, ...imgProps } = props;

const reactfireOptions: ReactFireOptions<string> = {
Expand Down
Loading