Repository navigation
Start the light paths of a camera behind a window pane at the pane - #184
Merged
Merged
Conversation
A camera that looks into the smoke through a window pane sees the LEDs along lines of sight whose part between the camera and the pane is free of smoke. Counted from the camera, the light paths were too long and the extinction coefficients too low, by half where the pane lies halfway. The pane is the plane through pane_point with the normal pane_normal. Both are optional options of [experiment_geometry] in config_analysis.ini and of every [simulation_N] in config_stacked.ini. With a pane, the light path of an LED starts where its line of sight crosses the pane, and the camera may stand outside domain_bounds as long as the light paths behind the pane lie inside. A pane that does not separate the camera from an LED is reported with the LED. The result headers name the pane. Without the options, or with None, the light paths and the result files stay as they were. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pane_point and pane_normal give way to a single option, pane_distance: the distance in m between the camera and the pane, in [experiment_geometry] of config_analysis.ini and in every [simulation_N] of config_stacked.ini. The pane is taken as normal to the line of sight, so the light path of every LED starts pane_distance away from the camera. A flat pane normal to the optical axis is crossed by a line of sight at 15 degrees to the axis 3.5 % farther away, which is negligible as long as the pane is close to the camera compared to the LEDs. An LED that is not farther away from the camera than the pane is reported, and the result headers name the distance. Without the option, or with None, the light paths and the result files stay as they were. The unit test that writes a config file names the encoding on the line of write_text, where the encoding check of the CI looks for it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kriboe90
added a commit
that referenced
this pull request
Nov 10, 2026
Brings the window pane (#184) to develop: pane_distance in config_analysis.ini and in every [simulation_N] of config_stacked.ini starts the light paths of a camera behind a pane at the pane. develop keeps its version 0.14.0.dev0. The conflicts were additions on both sides, the README sections and the arguments of ConfigDataAnalysis and of the keyword Create Test Data, and keep both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A camera that looks into the smoke through a window pane, for example from outside the test room, sees every LED along a line of sight whose part between the camera and the pane is free of smoke. LEDSA counted the whole line of sight from the camera, so the light paths were too long and the extinction coefficients too low, by half where the pane lies halfway between the camera and the LEDs.
What changes
config_analysis.ini,[experiment_geometry]: the new optionpane_distance, the distance in m between the camera and the pane. The template writes it asNone.config_stacked.ini: every[simulation_N]section takes apane_distanceof its own; the template has it commented out.pane_distanceaway from the camera (Experiment.calc_smoke_path_start), and only the part behind the pane is distributed over the layers. The camera itself may then stand outsidedomain_bounds, as long as the light paths behind the pane lie inside.pane_distancethat is not a number of at least 0 is reported with its section.Camera: (…), pane_distance: 0.5, and the stacked header every camera behind a pane,pane_distance: sim0 0.5 |.Backward compatibility. The option is optional. A config without it, or with
None, gives the light paths of before, and the result files stay the same, header included (see the test plan).Camera(x, y, z)and the methods ofExperimentkeep working as they are called now; the start of the light path is an optional argument that defaults to the camera.Approximation. A flat pane normal to the optical axis is crossed by a line of sight at an angle θ to the axis
pane_distance / cos θaway from the camera, notpane_distance: at 15°, 3.5 % farther. With the pane 0.5 m in front of the camera, the light path in the smoke of such an LED is taken 1.8 cm too long, which is negligible against light paths of several metres. In exchange, the pane needs no orientation, only its distance.Not corrected: the transmission of the pane itself. It cancels in I/I0 as long as it does not change, but a pane that gets sooted or fogged during the test dims the LEDs like smoke. Refraction in a pane with parallel faces only shifts the line of sight by less than the thickness of the pane.
Commits. The first commit described the pane by a point and a normal; the second replaces both by
pane_distance.Test plan
test_camera_pane.pycover the light paths behind a pane (shortened by the distance, a level line of sight, a pane at the camera, an LED nearer than the pane or on it, a camera above the layers, a crossing above the layers), the option in both config files and the pane of every camera of the stacked analysis. With the pane ignored, 9 of the 11 tests of the light paths fail; the other two have no pane or one at the camera.PYTHONPATHset to the branch), among them the new suite12_test_camera_pane.robot. Its synthetic images have smoke only behind a pane 2 m in front of the camera, about halfway to the LEDs 4 m away. Withpane_distance = 2inconfig_analysis.ini, the RMSE of k is 0.009 to 0.011 (limit 0.05, as in the other suites); without it, k of the constant extinction comes out at 0.52 of the input.sum_col_val,mean_col_valandmax_col_valwith-s3_fastand with-s3,average_images, nonlinear and stacked) are identical, headers included.write_text(whoseencodingwas on the next line.sphinx_copybutton, which isn't installed here).🤖 Generated with Claude Code