Skip to content

fix: honor fast step three for individual color channels - #180

Merged
kriboe90 merged 1 commit into
FireDynamics:masterfrom
imshah-id:fix/fast-channel-analysis
Nov 9, 2026
Merged

kriboe90 merged 1 commit into
FireDynamics:masterfrom
imshah-id:fix/fast-channel-analysis

Conversation

@imshah-id

Copy link
Copy Markdown
Contributor

Fixes #176.

-s3_fast -r, -g, and -b now run only fast step 3. Previously the and not args.step_3_fast guard applied only to -rgb, so individual color flags triggered a full LED fit before repeating the analysis without fits. Grouping the color flags applies the guard to every channel selection.

The regression tests parse real CLI flags and verify a single extractor invocation with the requested channels and fit mode. They cover each color, RGB, and a two-color selection with and without -s3_fast. Before the fix, four fast-mode cases failed because extraction ran twice.

Validation: python -m pytest ledsa/tests/UnitTests -q — 413 passed (one existing normalization warning), Python 3.12 on macOS. Robot Framework image acceptance tests were not run; this change affects dispatch, not the extraction algorithms.

@kriboe90
kriboe90 merged commit 1bbdef3 into FireDynamics:master Nov 9, 2026
1 check passed
kriboe90 added a commit that referenced this pull request Nov 9, 2026
Brings the fixes of the step 3 flags and the restart into develop:
#180 (-s3_fast with -r, -g or -b no longer
also runs the full step 3), #182 (a colour flag picks the channels of
-re instead of running step 3) and #183 (-re resumes in the fit mode
and in all channels of the interrupted run). They are merged before the
v0.13.0 cleanup (#181) lands on master, so that develop takes the fixes
without the removals.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kriboe90 added a commit that referenced this pull request Nov 9, 2026
…-0-cleanup-cea6d8

Brings the fixes of the step 3 flags and the restart (#180, #182, #183)
into the cleanup. Two conflicts, both from changes on adjacent lines:

- doc/cli_documentation.rst: the -s3_fast row keeps the description
  without the background-corrected sums and takes the channel flags.
- ledsa/data_extraction/step_3_functions.py: find_fit_leds_for_restart
  goes before _generate_led_analysis_data, which keeps the signature
  without the noise, side band and background floor parameters.

The restart reads the fit mode from the header line of the column
names, which still starts with id and lists fit_success only with the
fits, so it works with the shorter header of the cleanup.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

-s3_fast with -r, -g or -b also runs the full step 3 with LED fits

2 participants