Honor xsi:nil in any attribute position and xs:boolean form - #888
Open
Sahana2524 wants to merge 1 commit into
Open
Honor xsi:nil in any attribute position and xs:boolean form#888Sahana2524 wants to merge 1 commit into
xsi:nil in any attribute position and xs:boolean form#888Sahana2524 wants to merge 1 commit into
Conversation
🧪 Code Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xsi:nilis only recognized as an element's first attribute_checkXsiAttributesinspects attribute 0 only, so<price currency="USD" xsi:nil="true"/>deserializes to a populated object while the same element with those two attributes swapped gives null, and in the first form the marker leaks through as a property namednil. Since attribute order carries no meaning in XML andxsi:nilis typedxs:boolean, the lookup now scans the whole attribute list and accepts the other true forms, with the marker itself still hidden wherever it sits.