release: publish fbuild 2.5.7 dependency cascade - #1244
Conversation
Bump fbuild to 2.5.7 so the autonomous release publishes the completed running-process 4.8.1 and zccache 1.13.1 cascade. Exercise a real embedded compile twice to prove cache materialization and exported-symbol linkage. Refs #1239.
|
Warning Review limit reached
Next review available in: 43 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe project versions now use ChangesEmbedded zccache validation
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related issues
Possibly related PRs
Sequence Diagram(s)sequenceDiagram
participant SmokeTest
participant CCompiler
participant EmbeddedZccache
participant ObjectFile
SmokeTest->>CCompiler: cold compilation
CCompiler->>EmbeddedZccache: compile request
EmbeddedZccache->>ObjectFile: create object
SmokeTest->>EmbeddedZccache: flush cache and remove object
SmokeTest->>EmbeddedZccache: warm compilation
EmbeddedZccache->>ObjectFile: recreate object from cache
SmokeTest->>EmbeddedZccache: graceful shutdown
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Use fbuild_core::path::NormalizedPath for compiler discovery so the dependency cascade acceptance test satisfies the workspace PathBuf dylint. Refs #1239.
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/fbuild-build/tests/zccache_embedded_smoke.rs`:
- Around line 39-48: Replace the duplicated path-search iterator in the
compiler-name loop with calls to the existing on_path closure for each name.
Preserve the current return behavior by returning the first matching candidate
from on_path, keeping path resolution centralized and consistent.
- Line 9: Update the stale zccache version/revision comment associated with the
fbuild-build dependency to reflect revision
8cf6dd0ef5d6f2ff2980039290b9e498fb5a6b0e and version 1.13.1 instead of
1.12.17/5ee292f. If this change intentionally advances the dependency pin,
update the soldr _vender/zccache submodule to the matching revision.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 6c92b1bc-a45f-4512-bb94-53b060bf627e
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (3)
Cargo.tomlcrates/fbuild-build/tests/zccache_embedded_smoke.rspyproject.toml
Centralize smoke-test compiler lookup and update the embedded zccache pin comment to the released 1.13.1 revision. Refs #1239.
Follow-up to #1239 and #1243.
#1243 merged the validated running-process 4.8.1 / zccache 1.13.1 dependency cascade. This follow-up completes the release and acceptance evidence that could not land before #1243 auto-merged:
Validation:
The prior #1243 commit passed the complete Windows, Linux, macOS, lint, documentation, and board-build matrix.
Summary by CodeRabbit
New Features
Bug Fixes
Chores