Handle empty FanDuel projection responses - #168
Open
TheMathNinja wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
season, notweek)Diagnosis
FanDuel's current projections page and its
GetProjectionsGraphQL operation both report no NFL projections during the offseason. The scraper converted that empty response to a zero-column tibble, thenmutate(pos = ...)resolvedposto the six-element function argument and raised a misleading dplyr size error.This keeps the existing endpoint (which is still used by FanDuel's current page) and makes the legitimate empty-response state safe. It will continue processing if only some position groups are empty.
Verification
scrape_fanduel(pos = c("QB", "RB", "WR", "TE", "K", "DST"), season = 2026, week = 0)against the live endpoint.season = 2026andweek = 0attributes and the messageFanDuel returned no projections. Please check back later.R CMD checkreaches package metadata checks; a complete check is blocked by missing suggested packages (knitr,nflfastR,rmarkdown) and pre-existing repository/environment check issues.