Minor tweak to OpLightning implementation - #1303
Closed
Robotgiggle wants to merge 1 commit into
Closed
Robotgiggle wants to merge 1 commit into
Robotgiggle wants to merge 1 commit into
Conversation
Robotgiggle
added
optimization
object-Object
approved these changes
Sep 17, 2026
object-Object
left a comment
object-Object
left a comment
Member
There was a problem hiding this comment.
These changes LGTM, but can we change this to target 1.20?
Member
Author
|
1.20 version of the PR has been created (#1304). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described on Discord here, the current implementation of OpLightning doesn't allow the lightning bolt entity to be selected with things like zone distillations. It also doesn't currently attribute the bolt to the player who summoned it. This PR fixes both of those problems.