build(deps-dev): Bump jsdom from 29.1.1 to 30.0.0 - #610
Conversation
Bumps [jsdom](https://github.com/jsdom/jsdom) from 29.1.1 to 30.0.0. - [Release notes](https://github.com/jsdom/jsdom/releases) - [Commits](jsdom/jsdom@v29.1.1...v30.0.0) --- updated-dependencies: - dependency-name: jsdom dependency-version: 30.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
hermes-exosphere
left a comment
There was a problem hiding this comment.
✅ Auto-approved: all 10 CI checks passing. Ready to merge.
|
Automated code review started - full review. Results will be posted here. |
|
⏳ [progress] Phase 0-2 complete. Diff analyzed. Phase 3: starting build & test. |
|
BUILD AND TEST COMPLETE. Results:
Local environment: Node 22.23.1, Bun 1.3.14 See inline comment re: engines.node mismatch with jsdom 30.0.0 Node requirement. |
Automated Code ReviewExecutive SummaryThis is a Dependabot major-version bump of jsdom (devDependency) from 29.1.1 to 30.0.0. The change touches only package.json and bun.lock — zero application code modified. The sole breaking change is a raised Node.js engine floor that needs acknowledgment. All unit tests pass. Change Architecturegraph TD
A[package.json: jsdom 29.1.1] -->|"bump to 30.0.0"| B[package.json: jsdom 30.0.0]
B --> C[New: jsdom 30.0.0 deps]
C --> D1[asamuzakjp/css-color 5-6]
C --> D2[asamuzakjp/dom-selector 7-8]
C --> D3[whatwg-url 16-17]
C --> D4[undici 7-8]
C --> D5[tough-cookie 6.0.1-6.0.2]
C --> D6[lru-cache 11.5.1-11.5.2]
style C fill:#90EE90
style B fill:#FFD700
style A fill:#87CEEB
Legend: Green=New | Yellow=Breaking Change Risk | Blue=Modified Breaking Changes
Issues Found
Logical / Bug Analysis
Evidence — Build & Test ResultsBuild: bun install + next build compiles (Turbopack, 39.4s). 4 pre-existing Next.js build warnings (none new). Test: vitest run — 100+ test files, all passing. All vitest suites marked green. Issue LinkageNo linked issues. This is a Dependabot-initiated dependency bump. Human Review FeedbackNo human review comments on this PR. Only bot comments: Socket Security (2x obfuscated code alerts — false positive for jsdom) and hermes-exosphere (prior review placeholder). Suggestions
VerdictVERDICT: APPROVED_WITH_SUGGESTIONS Automated code review by Hermes Agent · 2026-07-27 21:46 UTC |
hermes-exosphere
left a comment
There was a problem hiding this comment.
Automated review: APPROVED_WITH_SUGGESTIONS.
One non-blocking suggestion: update engines.node to >=22.22.2 to match jsdom 30.0.0 Node requirement.
All tests pass. No application code changes. See summary comment for details.
hermes-exosphere
left a comment
There was a problem hiding this comment.
Automated review: Approved. ✅
Bumps jsdom from 29.1.1 to 30.0.0.
Release notes
Sourced from jsdom's releases.
Commits
20a01fc30.0.08c8e583Precompute WPT expectation matchesf32245cBump Node.js floor and dependencies03ef23bAdd background-position longhandsded056fTest CSS.escape() with numeric IDsd312832Convert CSS values to pixels for computed styles4e0ee41Implement CSS.escape() and CSS.supports()05eb709Fix benchmark:compare script on Windows97c1b90Fix CSS function value serialization15642baAdd benchmark comparison scriptDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)