Add invoice ZIP request methods - #11
Open
raul-facturapi wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support in the Java SDK for creating, listing, retrieving, and downloading invoice ZIP requests via the /v2/invoices/zip-requests endpoints, along with test coverage and a version bump for release.
Changes:
- Add ZIP request methods to
InvoicesResource(createZipRequest,listZipRequests,retrieveZipRequest,downloadZipRequest). - Add resource tests validating request method/path and basic payload/query behavior for the new endpoints.
- Bump SDK version to
1.4.0and document changes in the changelog.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/main/java/io/facturapi/resources/InvoicesResource.java |
Introduces new ZIP request endpoints under invoices, including a streaming download method. |
src/test/java/io/facturapi/FacturapiResourcesTest.java |
Adds tests covering the new ZIP request methods and expected HTTP interactions. |
pom.xml |
Bumps library version from 1.3.0 to 1.4.0. |
CHANGELOG.md |
Documents the new ZIP request methods in the 1.4.0 release entry. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+192
to
+200
| * Downloads the ZIP generated for a request. | ||
| * | ||
| * @param id ZIP request id. | ||
| * @return ZIP stream. Caller owns closing it. | ||
| * @see <a href="https://docs.facturapi.io/api#tag/Invoices">API reference</a> | ||
| */ | ||
| public InputStream downloadZipRequest(String id) { | ||
| return client.getStream("/invoices/zip-requests/" + id + "/zip"); | ||
| } |
javorosas
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.