Skip to content

chore(leyendasFiscales): add leyendas fiscales complement to document… - #290

Merged
raul-facturapi merged 1 commit into
mainfrom
chore/add_leyendas_fiscales_documentation
Aug 12, 2026
Merged

chore(leyendasFiscales): add leyendas fiscales complement to document…#290
raul-facturapi merged 1 commit into
mainfrom
chore/add_leyendas_fiscales_documentation

Conversation

@raul-facturapi

Copy link
Copy Markdown
Collaborator

…ation

@raul-facturapi
raul-facturapi requested review from edgtz and javorosas and a lite review from Copilot August 12, 2026 16:33
@raul-facturapi raul-facturapi self-assigned this Aug 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the “Leyendas Fiscales” (v1.0) complement to the OpenAPI v2 documentation, extending the existing complement discriminator to support a new leyendas_fiscales type in both Spanish and English specs.

Changes:

  • Introduces LeyendasFiscalesProperties / LeyendasFiscalesInput schemas and wires them into the complement discriminator mapping.
  • Extends complement type enums to include leyendas_fiscales.
  • Adds the LeyendasFiscalesData schema describing the complement payload structure.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
website/openapi_v2.yaml Adds Leyendas Fiscales complement schemas, discriminator mapping, enums, and data model (Spanish).
website/openapi_v2.en.yaml Mirrors the Leyendas Fiscales complement additions in the English OpenAPI spec.
Suppressed comments (4)

website/openapi_v2.yaml:13354

  • LeyendasFiscalesInput currently references LeyendasFiscalesData, but the surrounding patterns use *DataInput for request payloads (e.g., ComercioExteriorInput -> ComercioExteriorDataInput at openapi_v2.yaml:13340). It would be clearer to reference a LeyendasFiscalesDataInput alias.
              $ref: "#/components/schemas/LeyendasFiscalesData"

website/openapi_v2.yaml:13399

  • To match the established *DataProperties / *DataInput naming convention for complements, add lightweight alias schemas for LeyendasFiscalesData and reference those from LeyendasFiscalesProperties/LeyendasFiscalesInput. This keeps the schema DRY while staying consistent with the rest of the spec.
    LeyendasFiscalesData:
      type: object
      title: LeyendasFiscales
      description: Complemento de Leyendas Fiscales versión 1.0.

website/openapi_v2.en.yaml:13149

  • LeyendasFiscalesInput currently references LeyendasFiscalesData, but other request payload schemas consistently use *DataInput (e.g., ComercioExteriorInput -> ComercioExteriorDataInput at openapi_v2.en.yaml:13135). It would be clearer to reference a LeyendasFiscalesDataInput alias.
              $ref: "#/components/schemas/LeyendasFiscalesData"

website/openapi_v2.en.yaml:13194

  • To align with the established *DataProperties / *DataInput convention used by other complements, add alias schemas for LeyendasFiscalesData and then reference those from LeyendasFiscalesProperties/LeyendasFiscalesInput. This helps keep the English spec consistent with the Spanish one and with existing generator expectations.
    LeyendasFiscalesData:
      type: object
      title: LeyendasFiscales
      description: Fiscal Legends complement version 1.0.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread website/openapi_v2.yaml
- type: object
properties:
data:
$ref: "#/components/schemas/LeyendasFiscalesData"
- type: object
properties:
data:
$ref: "#/components/schemas/LeyendasFiscalesData"
@raul-facturapi
raul-facturapi merged commit a784ca3 into main Aug 12, 2026
1 check passed
@raul-facturapi
raul-facturapi deleted the chore/add_leyendas_fiscales_documentation branch August 12, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants