chore(leyendasFiscales): add leyendas fiscales complement to document… - #290
Merged
Merged
Conversation
raul-facturapi
requested review from
edgtz and
javorosas
and
a lite review from Copilot
August 12, 2026 16:33
edgtz
approved these changes
Aug 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the “Leyendas Fiscales” (v1.0) complement to the OpenAPI v2 documentation, extending the existing complement discriminator to support a new leyendas_fiscales type in both Spanish and English specs.
Changes:
- Introduces
LeyendasFiscalesProperties/LeyendasFiscalesInputschemas and wires them into the complement discriminatormapping. - Extends complement
typeenums to includeleyendas_fiscales. - Adds the
LeyendasFiscalesDataschema describing the complement payload structure.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| website/openapi_v2.yaml | Adds Leyendas Fiscales complement schemas, discriminator mapping, enums, and data model (Spanish). |
| website/openapi_v2.en.yaml | Mirrors the Leyendas Fiscales complement additions in the English OpenAPI spec. |
Suppressed comments (4)
website/openapi_v2.yaml:13354
LeyendasFiscalesInputcurrently referencesLeyendasFiscalesData, but the surrounding patterns use*DataInputfor request payloads (e.g.,ComercioExteriorInput->ComercioExteriorDataInputat openapi_v2.yaml:13340). It would be clearer to reference aLeyendasFiscalesDataInputalias.
$ref: "#/components/schemas/LeyendasFiscalesData"
website/openapi_v2.yaml:13399
- To match the established
*DataProperties/*DataInputnaming convention for complements, add lightweight alias schemas forLeyendasFiscalesDataand reference those fromLeyendasFiscalesProperties/LeyendasFiscalesInput. This keeps the schema DRY while staying consistent with the rest of the spec.
LeyendasFiscalesData:
type: object
title: LeyendasFiscales
description: Complemento de Leyendas Fiscales versión 1.0.
website/openapi_v2.en.yaml:13149
LeyendasFiscalesInputcurrently referencesLeyendasFiscalesData, but other request payload schemas consistently use*DataInput(e.g.,ComercioExteriorInput->ComercioExteriorDataInputat openapi_v2.en.yaml:13135). It would be clearer to reference aLeyendasFiscalesDataInputalias.
$ref: "#/components/schemas/LeyendasFiscalesData"
website/openapi_v2.en.yaml:13194
- To align with the established
*DataProperties/*DataInputconvention used by other complements, add alias schemas forLeyendasFiscalesDataand then reference those fromLeyendasFiscalesProperties/LeyendasFiscalesInput. This helps keep the English spec consistent with the Spanish one and with existing generator expectations.
LeyendasFiscalesData:
type: object
title: LeyendasFiscales
description: Fiscal Legends complement version 1.0.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| - type: object | ||
| properties: | ||
| data: | ||
| $ref: "#/components/schemas/LeyendasFiscalesData" |
| - type: object | ||
| properties: | ||
| data: | ||
| $ref: "#/components/schemas/LeyendasFiscalesData" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ation