Skip to content

Fix time-bomb test fixture: dynamic expires_at in commit.test.ts #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
admdly merged 1 commit into from
Aug 28, 2026
Merged

Fix time-bomb test fixture: dynamic expires_at in commit.test.ts #206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions test/services/previews/v1/commit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,23 @@ import { request as ghRequest } from "@octokit/request";

const SHA = "a1b2c3d4e5f6a1b2c3d4e5f6a1b2c3d4e5f6a1b2";

// A fixed calendar date here would eventually land in the past and make
// ttlForArtifact() compute a negative TTL, silently disabling the caching
// these tests exist to verify - GitHub's own artifact retention is 14
// days, so anything comfortably longer reads as "not expiring any time
// soon" for as long as this suite keeps running.
const FAR_FUTURE_EXPIRES_AT = new Date(
Date.now() + 365 * 24 * 60 * 60 * 1000
).toISOString();

const SAMPLE_ARTIFACTS = {
total_count: 1,
artifacts: [
{
id: 555,
size_in_bytes: 12345,
created_at: "2026-08-13T10:00:00Z",
expires_at: "2026-08-27T10:00:00Z",
expires_at: FAR_FUTURE_EXPIRES_AT,
expired: false,
digest: "sha256:deadbeef",
workflow_run: { id: 999, head_sha: SHA }
Expand Down Expand Up @@ -297,7 +306,7 @@ describe("Previews API v1 - GET /previews/v1/commit/:sha", () => {
name: "FOSSBilling-preview-deadbee.zip",
size_in_bytes: 99,
created_at: "2026-08-13T11:00:00Z",
expires_at: "2026-08-27T11:00:00Z",
expires_at: FAR_FUTURE_EXPIRES_AT,
expired: false,
digest: "sha256:fromfork",
workflow_run: { id: 888, head_sha: SHA }
Expand Down Expand Up @@ -354,7 +363,7 @@ describe("Previews API v1 - GET /previews/v1/commit/:sha", () => {
name: "FOSSBilling-preview-deadbee.zip",
size_in_bytes: 99,
created_at: "2026-08-13T11:00:00Z",
expires_at: "2026-08-27T11:00:00Z",
expires_at: FAR_FUTURE_EXPIRES_AT,
expired: false,
digest: "sha256:page6",
workflow_run: { id: 888, head_sha: SHA }
Expand Down
Loading