Skip to content

Add FAF Tournaments OAuth client#326

Open
Nuggets75 wants to merge 2 commits into
FAForever:developfrom
Nuggets75:faf-tournaments-oauth
Open

Add FAF Tournaments OAuth client#326
Nuggets75 wants to merge 2 commits into
FAForever:developfrom
Nuggets75:faf-tournaments-oauth

Conversation

@Nuggets75

@Nuggets75 Nuggets75 commented Jul 13, 2026

Copy link
Copy Markdown

Adds an OAuth client for FAF Tournaments, a self-hosted tournament manager.

Website: https://tournaments.doodlepros.com
Redirect URI: https://tournaments.doodlepros.com/auth/faf/callback
Requested scopes: openid, offline, public_profile

The real client secret is not included in this PR.

Summary by CodeRabbit

  • New Features
    • Added OAuth support for the FAF Tournaments application.
    • Configured authorization code and refresh token flows, redirect settings, scopes, and application branding.
    • Added the required tournament application secret configuration.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c6c43282-fecf-4822-bd3f-008f6ecc3478

📥 Commits

Reviewing files that changed from the base of the PR and between 9963630 and fd5dc65.

📒 Files selected for processing (2)
  • apps/ory-hydra/templates/local-secret.yaml
  • apps/ory-hydra/values.yaml

📝 Walkthrough

Walkthrough

Ory Hydra now includes a FAF Tournaments OAuth client configured with authorization code and refresh token grants, required scopes and redirect settings, plus a corresponding FAFTOURNEY_SECRET Kubernetes Secret entry.

Changes

OAuth client registration

Layer / File(s) Summary
FAF Tournaments client and secret
apps/ory-hydra/templates/local-secret.yaml, apps/ory-hydra/values.yaml
Adds the FAFTOURNEY_SECRET Secret entry and registers the FAF Tournaments OAuth client with its credentials, grants, scopes, URIs, and token endpoint authentication method.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding an OAuth client for FAF Tournaments.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant