Skip to content

ci: add Needs review status to the board sweep - #651

Merged
LeeroyHannigan merged 1 commit into
mainfrom
board-sweep-needs-review
Oct 29, 2026
Merged

LeeroyHannigan merged 1 commit into
mainfrom
board-sweep-needs-review

Conversation

@navareamol

Copy link
Copy Markdown
Collaborator

Summary

Adds a Needs review status to the Roadmap board sweep, between In Progress and Review. Today a ready PR that nobody has reviewed sits in In Progress, mixed in with drafts. This makes the review queue its own column.

How a PR moves

Todo -> In Progress -> Needs review -> Review -> Done

PR state Status
Draft In Progress
Latest review from someone requests changes, and they haven't been asked again In Progress
Ready, no review from another person yet Needs review (was In Progress)
Changes requested, and every such reviewer was asked to review again Needs review (was Review)
Reviewed by another person (approve, comment review, dismissed), nothing blocking Review
Merged Done (built-in workflow, unchanged)

Issues are unchanged in logic: an issue takes the furthest status of its trusted open linked PRs, so an issue whose PR waits on a reviewer is now in Needs review.

Use cases

  • Reviewer looking for work: filter the board by Needs review to see every PR waiting on a reviewer.
  • Author pushes fixes and re-requests review: the card goes back to Needs review, so the reviewer sees it again.
  • Work in progress: open it as a draft PR. It stays In Progress until marked ready.

Failure and edge cases

  • Board has no "Needs review" option yet: cards that would move there are left as they are, and the run is reported as degraded on the private health card. Nothing breaks. Add the option before merging to avoid this.
  • Re-request only some blocking reviewers: stays In Progress, as before.
  • Re-requested reviewer plus a separate approval: Needs review. The re-requested reviewer still has to look.
  • Author's own comments, bots, pending reviews: still don't count as a review, so the PR stays in Needs review.
  • Non-draft PR that isn't really ready: shows in Needs review. Use draft PRs for unfinished work.
  • Hand moves, Auto status = Off, closed, archived and unknown statuses: handled exactly as before. "Needs review" is now a managed status.

Testing

  • 51 tests (46 existing, updated where the expected status changed, plus 5 new): draft vs ready, re-request with a separate approval, issue following a Needs review PR, issue taking its furthest PR, Todo -> Needs review.
  • Ran the new tests against the old sweep code: 16 fail, so they check the new rule.
  • The privacy test now also checks that "Needs review" never reaches the public log.

A ready PR waiting on a reviewer now gets Needs review instead of
In Progress, so the review queue is visible on its own. This covers a
non-draft PR with no review yet, and one whose changes-requested
reviewers have all been asked to review again. Drafts and PRs with an
outstanding changes-requested verdict stay In Progress. Issues follow
their furthest linked PR, as before.
@LeeroyHannigan
LeeroyHannigan added this pull request to the merge queue Oct 29, 2026
Merged via the queue into main with commit 07a49b0 Oct 29, 2026
28 checks passed
@LeeroyHannigan
LeeroyHannigan deleted the board-sweep-needs-review branch October 29, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants