Repository navigation
Update example minimatch to 3.1.5 - #344
Merged
Merged
Conversation
AndrewGable
marked this pull request as ready for review
November 12, 2026 00:11
melvin-bot
Bot
requested review from
carlosmiceli
and removed request for
a team
November 12, 2026 00:11
carlosmiceli
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Resolve the example application's transitive
minimatchdependency to^3.1.5and update its Yarn lockfile from 3.0.4 to 3.1.5. Existing consumers request^3.0.4, so this preserves the current major version and CommonJS interface. Only the example manifest and minimatch lock entry change.Version 3.1.5 falls outside the vulnerable ranges listed on all four open minimatch alerts. The existing Dependabot PR targets 3.1.2, which still falls within three of those ranges.
Review limitation: matching the advisory version ranges does not establish safety for arbitrary untrusted patterns. Direct tests on 3.1.5 still stalled on the nested extglob advisory example and on a pattern with separated repeated wildcards. Each process was stopped by a timeout. The upstream 3.1.5 security guidance explicitly warns about untrusted patterns. This draft records that limitation and does not claim complete ReDoS protection. A broader tooling or matching change needs a separate compatibility review.
Fixed Issues
For https://github.com/Expensify/Expensify/issues/701864
AI Tests
react-nativewhen loading the parent library'sindex.js. No tests execute. This existing harness problem is outside the dependency update.yarn listconfirms minimatch 3.1.5.git diff --check, and verified the committed version and ordinary matching after committing. No new test files or infrastructure were added.Tests
example, install usingyarn installwith the frozen lockfile option on Node 20.yarn listwith the minimatch pattern and confirm 3.1.5 is installed.QA
Keep this PR in draft pending review of the residual pattern risk and existing Jest harness failure. No native application code changed.
PR Author Checklist