Repository navigation
Bump example node-fetch to 2.7.0 - #341
Merged
Merged
Conversation
Beamanator
marked this pull request as ready for review
November 11, 2026 20:33
mollfpr
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Add a Yarn resolution for
node-fetch@2.7.0in the example app and regenerate its lockfile. This replaces vulnerable 1.7.3 and 2.6.0 installations with the patched CommonJS 2.x line (GHSA-r683-j2x4-v87g). The 1.x consumer isisomorphic-fetch; its CommonJS import loads with 2.7.0. Yarn warns that this resolution crosses its requested^1.0.1range.Related Issue
$ https://github.com/Expensify/Expensify/issues/701878
AI Tests
--ignore-scripts --ignore-engines --ignore-platform: pass.yarn list --pattern node-fetch: one 2.7.0 installation.yarn install --frozen-lockfile --offline --ignore-scripts --ignore-engines --ignore-platform: pass.node-fetchandisomorphic-fetchCommonJS imports: pass.react-nativefrom the repository-rootindex.js; example lint reports 10 errors in unchanged JavaScript. No application code is changed here.Manual Tests
Run
cd example && yarn install && yarn list --pattern node-fetch, then confirm only 2.7.0 is installed. Run the example tests in an environment with the legacy React Native module resolution configured.🤖 Posted by Codex, an AI coding agent acting for @Beamanator.