Fix invoice fields collision, downgrade, and copy root causes - #101470
Open
ShridharGoel wants to merge 3 commits into
Open
ShridharGoel wants to merge 3 commits into
ShridharGoel wants to merge 3 commits into
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
ShridharGoel
marked this pull request as ready for review
September 17, 2026 21:15
melvin-bot
Bot
requested review from
rojiphil
and removed request for
a team
September 17, 2026 21:15
ShridharGoel
requested review from
mollfpr
and removed request for
garrettmknight and
rojiphil
September 17, 2026 21:15
melvin-bot
Bot
requested review from
rojiphil
and removed request for
a team
September 17, 2026 21:15
Contributor
|
Reviewing today |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixes root causes across three related invoice fields issues:
canPolicyAccessFeatureso downgraded Collect workspaces do not keep invoice fields enabled or accessible.isInvoiceFieldsEnabled) in copy settingshasInvoiceConfigurationso the Invoices setting is presented when invoice fields are enabled with 0 fields created.Fixed Issues
$ #100876
$ #100878
$ #100879
Tests
Field collision message (Invoices - Wrong error message when creating invoice field with the same name as report field #100876):
PO Number.PO Number.Client Ref.Client Ref.Downgrade to Collect (Invoices - Invoice fields remain enabled after downgrading workspace to Collect #100878):
/settings/workspaces/:policyID/invoices/fields/new).Copy settings visibility (Invoices - No option to copy settings when invoice fields are enabled without invoice fields #100879):
Offline tests
Same as tests above.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots / Videos
Web
Screen.Recording.2026-09-18.at.2.38.32.AM.mov
Screen.Recording.2026-09-18.at.2.34.12.AM.mov
Screen.Recording.2026-09-18.at.2.36.53.AM.mov