Repository navigation
test(mesh): check a server stepped down to etcd-only gives the Lease back - #138
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins. |
…back The stepped-down server has no API server, so the release goes through another server's. The scenario now waits for the Lease to be free rather than expired, and fails if the service logged that it could not release it. The harness inventory also turns the runtime autostart off, so a run against a Colima profile installs no login item.
5d2e53d to
68c5fe2
Compare
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
🎉 This PR is included in version 2.7.9 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Stepping a server down to
etcd-onlydoes release thefleet-regradeLease, from another server's API throughKUBE_SERVER, so the suspicion in the issue does not hold: the regrade scenario now passes with the Lease free after both a watcher step and a step by hand. Breakingrelease_leasemakes the scenario fail on the new wait, so the check discriminates.The harness inventory also sets
github_runner_cluster_runtime_autostart: false: a run against a Colima Docker context otherwise installs a launchd login item for the host's profile.Fixes #131