Repository navigation
fix(cluster): report a first run's Compose start under --check - #123
Merged
Merged
Conversation
A first run's dry run creates no project directory, and the Compose module fails on a project directory that does not exist, so a dry run of a cluster's first deploy on a host, such as a second cluster beside the first, stopped at the start of its first server. The role now reads whether the directory exists before each server's and agent's start and, under --check with no directory yet, reports the start it would make instead of asking Compose. Fixes #122
Mearman
marked this pull request as ready for review
October 20, 2026 21:18
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins. |
|
🎉 This PR is included in version 2.6.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #122. Under
--checkthe role creates no project directory, anddocker_compose_v2refuses aproject_srcthat does not exist, so a dry run of a cluster's first deploy on a host stopped at its first server's start. Each server's turn (tasks/start_server.yml) and the agent's start now read whether the directory exists first and, under--checkwith none yet, skip Compose and report the start they would make (Would create <dir> and start the k3s server there, as <container> in the Compose project <project>, changed). A real run, or a dry run on a host that already has the directory, asks Compose as before.The node password and recreate tests' harness now creates each node's project directory, as every earlier real run has, and
tests/unit/test_server_recreate.pygains a dry run with no directories (reported, no Compose call, nothing created) and one with them (Compose asked in check mode, nothing reported). Seen against live hosts dry-running a second cluster beside the first with v2.5.0, where every task before the start passed.