feat(odf.js): write .ott/.ots/.otp/.otg templates, and their .stw/.stc/.sti/.std counterparts - #910
Merged
Merged
Conversation
Mearman
marked this pull request as ready for review
September 4, 2026 12:01
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Mearman
force-pushed
the
feat/odf-ooo1-template-write
branch
from
September 4, 2026 12:02
53c752d to
1d6efba
Compare
…c/.sti/.std counterparts writeOdtContent/writeOdsContent/writeOdpContent/writeOdgContent could only ever stamp a document's base ODF media type, even though the reader already accepted a template's content.xml/styles.xml as structurally identical to its non-template counterpart. A template write option therefore needed nothing beyond selecting which media type createOdfPackage stamps: syncManifest already derives the manifest root entry from whatever readMimetype(pkg) reports, so stamping ODF_MEDIA_TYPES.ott/.ots/.otp/.otg instead of the base type is the whole change. The OpenOffice.org 1.x writers (writeSxw/writeSxc/writeSxi/writeSxd) need no code of their own to inherit this: each already threads its own options straight through to the ODF writer it wraps, and transformToOoo1Package already derives the package's own .stw/.stc/ .sti/.std media type from whatever ODF media type it finds stamped on the package via the existing ooo1MediaTypeForOdfMediaType table. Verified against real LibreOffice 26.2.5.2: an .ott/.ots built with template: true, and a .stw/.stc built the same way through the OpenOffice.org 1.x writers, all convert cleanly and are correctly identified as genuine Writer/Calc documents from their media type alone, regardless of file extension.
Mearman
force-pushed
the
feat/odf-ooo1-template-write
branch
from
September 4, 2026 12:05
1d6efba to
0be7e8c
Compare
Contributor
|
🎉 This PR is included in version 6.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
writeOdtContent/writeOdsContent/writeOdpContent/writeOdgContent could only ever stamp a document's base ODF media type, even though the reader already accepted a template's content.xml/styles.xml as structurally identical to its non-template counterpart. A template write option needed nothing beyond selecting which media type createOdfPackage stamps: syncManifest already derives the manifest root entry from whatever readMimetype(pkg) reports, so stamping ODF_MEDIA_TYPES.ott/.ots/.otp/.otg instead of the base type is the whole change.
The OpenOffice.org 1.x writers (writeSxw/writeSxc/writeSxi/writeSxd) need no code of their own to inherit this: each already threads its own options straight through to the ODF writer it wraps, and transformToOoo1Package already derives the package's own .stw/.stc/.sti/.std media type from whatever ODF media type it finds stamped on the package, through the existing ooo1MediaTypeForOdfMediaType table.
Verified against real LibreOffice 26.2.5.2: an .ott/.ots built with
template: true, and a .stw/.stc built the same way through the OpenOffice.org 1.x writers, all convert cleanly and are correctly identified as genuine Writer/Calc documents from their media type alone, regardless of file extension.This completes the read+write scope #821 itself states, including the .stw/.stc/.sti/.std template counterparts.
Closes #821