Repository navigation
fix(statusline): read a reset time a Date cannot hold as absent - #625
Merged
Merged
Conversation
A reset instant in the client's rate_limits payload, or an Antigravity bucket's seconds to reset, was turned into an ISO string with toISOString, which throws for an instant beyond the range a Date holds, so the statusline exited with nothing drawn. Such a reset now reads as absent and its window is still drawn. Fixes #624
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A reset instant in the client's
rate_limitspayload, or an Antigravity bucket's seconds to reset, was turned into an ISO string withtoISOString, which throws for an instant beyond the range aDateholds, soagent-shim statuslineexited 1 with nothing drawn (#624).A reset like that now reads as absent and its window is still drawn. Two tests cover the two sites, and each fails against the old call at its site.
Fixes #624