Repository navigation
fix(frontdoor): let the probes take the bound they wait for - #623
Merged
Merged
Conversation
The tests that read the verdict of a probe ran it under the bound production uses, so on a loaded machine the worker thread's start alone could outlast it and the test saw the probe's own timeout where it was asking what a refused connection looks like. Both probes now take the bound as a parameter that defaults to the production one, and the tests that read a verdict give them a bound no loaded machine reaches. The test of the bound itself keeps the production value, and a new one pins that the bound given is the one the probe gives up at. Fixes #604
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The probe tests that read a verdict ran the probe under the production bound, so on a loaded machine starting the worker thread alone could outlast it and the test saw "the probe did not finish within 3000ms" where it was asking what a refused connection looks like (#604).
probeFrontDoorSyncandprobeListenerAcceptSyncnow take the bound as a parameter that defaults toPROBE_TIMEOUT_MS, the same way the statusline ports take their run limit. The tests that read a verdict give them a bound no loaded machine reaches; the test of the bound itself keeps the production one, and a new test pins that the bound a caller gives is the one the probe gives up at.Fixes #604