Repository navigation
fix(frontdoor): find a supervised session without blocking the door - #622
Merged
Merged
Conversation
An `acct:` model move looked up the session's supervisor registry entry with a synchronous `ps` liveness check, which the door refuses by design, so the request threw for any live supervised session instead of leaving the move for its supervisor. The lookup now reads liveness once without blocking, across every pool, and the route's `accountMoves` port resolves asynchronously.
Mearman
marked this pull request as ready for review
October 27, 2026 19:16
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An
acct:model move callssupervisedSessionOffrom the door's route resolver withrealIsProcessRunning, whose zombie check is a synchronouspsthatrefuseToBlockInRolerejects inside the door. For any live supervised session the request therefore threw instead of leaving a move request for the supervisor.supervisedSessionOfnow takesrunningAmongand lists every pool's entries before one non-blocking liveness read, pruning dead entries asliveSuperviseddoes;accountMovesresolves to a promise and the route awaits it. The new in-door test fails against the synchronous check. Same class as #621.