feat: ShowingHitMarkerEventArgs#791
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Player event to allow plugins to observe/modify (or deny) hitmarker display before it is sent to a client.
Changes:
- Introduces
Handlers.Player.ShowingHitMarkerand its invokerOnShowingHitMarker. - Adds a Harmony transpiler patch for
Hitmarker.SendHitmarkerDirectly(...)to raise the event and apply modified args / cancellation. - Adds
ShowingHitMarkerEventArgscarrying size, audio flag, hitmarker type, and a deniableIsAllowed.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
EXILED/Exiled.Events/Patches/Events/Player/ShowingHitMarker.cs |
Hooks Hitmarker.SendHitmarkerDirectly to invoke the new event and optionally block/override hitmarker parameters. |
EXILED/Exiled.Events/Handlers/Player.cs |
Exposes the new ShowingHitMarker event and adds the corresponding OnShowingHitMarker invoker. |
EXILED/Exiled.Events/EventArgs/Player/ShowingHitMarkerEventArgs.cs |
Defines the event args used by the new event, including overridable parameters and IsAllowed. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
why copilot is here bruh ? |
Author
Idk he want to cook XD |
Collaborator
|
@louis1706 if you remember Joker's new plans for Exiled 10, I dont think we should implement this event as a transpiler considering the LabAPI equivalent already exists. I've just pinged Joker for some more clarification on whether we should implement this event as a wrapper anyways but we'll have to wait for his response |
8 tasks
louis1706
approved these changes
Jul 16, 2026
VALERA771
approved these changes
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Added new event ShowingHitMarker
What is the current behavior? (You can also link to an open issue here)
What is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other