fix: declare the MIT licence the repository already carries - #24
Merged
Conversation
Every push to nuget.org warns "License missing" and the published package carries no licence expression, so nuget.org shows nothing where the licence link belongs and a compliance scanner has nothing to read. The repository has shipped an MIT LICENSE all along. One of eight: the same line was missing from every published Evergine.Bindings package. Each repository's own LICENSE was checked rather than assumed before writing MIT here.
The first version of this change read the file as utf-8-sig and wrote it back as plain utf-8, which silently dropped the BOM and turned a one-line addition into a two-line diff. Restored: the only change is now the licence line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every push to nuget.org warns
License missingand the published package carries no licence expression, so nuget.org shows nothing where the licence link belongs and a compliance scanner has nothing to read. The repository has shipped an MITLICENSEall along.One of eight: the same line was missing from every published
Evergine.Bindingspackage. Each repository's ownLICENSEwas read and confirmed MIT before writing it here, rather than assumed.Verified on Cesium.NET by packing locally, where the nuspec then carried
<license type="expression">MIT</license>.