[EricTechPro]

Note

⏳ In review · round 1 · ✅ 8/8 AC · Closes #34 · Closes #36 · head 996a65d

Problem

• ✨ [feat] codex-lane: reject malformed lane results in full #34 Where: scripts/super-board-codex-lane.sh, after codex exec returns
  • a. The lane hands Codex a strict --output-schema (six required keys, no extras)
  • b. The launcher only checked status, column and detail, so a non-string prUrl, an extra key or a half-filled priorFindings passed through as valid
  • c. Nothing pinned that schema to STAGE_SCHEMA in workflows/super-board-wave.js
• 🧪 [test] codex-wave: pin wave summary keys to the workflow's #36 Where: scripts/super-board-codex-wave.sh, the hand-built card summaries
  • a. The verification-readiness and skills-readiness halts built summaries without prUrl and priorFindings, unlike the workflow's summary
  • b. No test compared the Codex wave's summary keys to the workflow's
• Who: super-board run --codex and the orchestrator's Reconcile step (part of First-class Codex and OpenCode support with shared workflow core and native adapters #30)

Solution

• The lane validates the whole result against the schema it already builds: types, required keys, no extra keys, priorFindings null or three integer counts (booleans rejected). Anything else prints status: failed and exits 1
• tests/test_codex_lane_schema.py reads both schemas from source (Python ast for the lane, node for STAGE_SCHEMA) and fails if the status enum, field names or priorFindings keys differ
• The two up-front halt summaries in the Codex wave now carry prUrl: null and priorFindings: null
• tests/test-codex-wave-contract.sh reads the summary keys from the workflow's summary object and checks every card in normal, bounced, halted-while-grading, verification-readiness and skills-readiness waves, plus a boolean halted
• The stubbed codex moved to tests/fixtures/fake_codex.py so both Codex suites share it; it also takes SB_CODEX_TEST_RESULT for verbatim results

Acceptance criteria

• ✨ [feat] codex-lane: reject malformed lane results in full #34: non-string prUrl, an extra key, or priorFindings missing notFixed print status: failed and exit 1
  ↳ tests/test-codex-lane.sh "malformed result must fail" (8 cases)
• ✨ [feat] codex-lane: reject malformed lane results in full #34: a valid result, including prUrl: null and priorFindings: null, prints unchanged and exits 0
  ↳ tests/test-codex-lane.sh "valid result must print unchanged" (null and filled cases)
• ✨ [feat] codex-lane: reject malformed lane results in full #34: an offline test fails if STAGE_SCHEMA's status enum or property names differ from the lane schema
  ↳ tests/test_codex_lane_schema.py; checked red by adding an enum value and renaming branch
• 🧪 [test] codex-wave: pin wave summary keys to the workflow's #36: a new test fails if a Codex wave card summary has a missing or extra key
  ↳ tests/test-codex-wave-contract.sh; red before the fix on the readiness halt (missing prUrl, priorFindings)
• 🧪 [test] codex-wave: pin wave summary keys to the workflow's #36: covers normal, bounced and halted-while-grading paths with the stubbed codex
  ↳ same test, plus both readiness halts
• 🧪 [test] codex-wave: pin wave summary keys to the workflow's #36: expected keys come from workflows/super-board-wave.js
  ↳ checked red by renaming lastLane in the workflow
• bash tests/run-safety.sh passes on python 3.9
  ↳ PASS 61 suites
• bash tests/run-safety.sh passes on python 3.12
  ↳ PASS 61 suites

Iteration history

Lane	Done	Time	Details
🔨 builder	✅	Oct 19	bash tests/run-safety.sh → PASS 61 suites (py3.9, py3.12) · 996a65d

Risk

🟢 Low · stricter validation on one launcher; a schema-valid lane result prints unchanged. The wave change only adds two null keys to halt summaries.

🤖 Generated with Claude Code

[qodo-code-review]

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →