fix(test): isolate home state under CI quality gates#436
Merged
Conversation
Deploying allagents with
|
| Latest commit: |
d3ec4bb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://81ebefb3.allagents.pages.dev |
| Branch Preview URL: | https://fix-ci-authoritative-test-is.allagents.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Home-scoped tests no longer read or mutate real user state under Bun 1.3.13. A clearly owned
ALLAGENTS_TEST_HOMEoverride gives tests deterministic isolation even after Bun cachesos.homedir(), while production continues to use the Windows-safeos.homedir()path from #434.Broad quality checks now run authoritatively in GitHub Actions as separate Build, Typecheck, Lint, and Test jobs. The automatic prek pre-push installation and dependency are removed, and the permanently stale Bats command is replaced by a
test:e2escript backed by the repository's nine tracked Bun E2E files.Existing clones may retain a generated prek hook; contributors should inspect and remove only that generated hook if it still runs after updating.
Validation
Red reproductions before the fix:
The first command showed
afterremained/home/entity; the prune suite failed its user-plugin case because it read the real home.Green checks:
Built CLI E2E:
This created and updated an empty Claude workspace successfully, reported no plugins to update, and kept all generated home/workspace state under the temporary root.
Maintainer action
After this workflow lands, configure the
Build,Typecheck,Lint, andTestchecks as required checks formainbranch protection.Post-Deploy Monitoring & Validation
No application-runtime monitoring is required because this changes test isolation and repository quality gates. For the first pull request after merge, a maintainer should verify that all four CI jobs appear independently and complete successfully; missing jobs or unexpectedly green tests after a deliberate failure are rollback triggers for the workflow change.