fix(cli): simplify interactive plugin update label#435
Merged
Conversation
Deploying allagents with
|
| Latest commit: |
4ca0bd8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5f3fb2de.allagents.pages.dev |
| Branch Preview URL: | https://fix-interactive-updated-labe.allagents.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updating one installed plugin from the interactive plugin detail screen now completes with
◇ Updatedinstead of◇ Updated and synced. The update still performs its existing automatic sync; only the combined completion label changes. Install, remove, skills, mode-toggle, and bulk-update messages remain unchanged because they are separate interactive actions.Validation
bun run build— passed; bundled CLI containss.stop("Updated")for the single-plugin update action.bun test src/cli/tui/__tests__ tests/unit/cli/tui-cache.test.ts tests/unit/cli/tui-context.test.ts tests/unit/cli/tui/prompt-clients.test.ts— passed: 26 tests, 0 failures.bun run typecheck— passed.bun run lint— passed: 86 files checked, no fixes.Manual interactive E2E used a temporary workspace, isolated
HOME, and a local marketplace containing an embeddeddemoplugin:bun run build HOME=/tmp/allagents-updated-label-e2e.8deM8Q/home /home/entity/projects/EntityProcess/allagents__worktrees/fix-interactive-updated-label/dist/index.js init . --client universal HOME=/tmp/allagents-updated-label-e2e.8deM8Q/home /home/entity/projects/EntityProcess/allagents__worktrees/fix-interactive-updated-label/dist/index.js plugin marketplace add /tmp/allagents-updated-label-e2e.8deM8Q/marketplace --scope user HOME=/tmp/allagents-updated-label-e2e.8deM8Q/home /home/entity/projects/EntityProcess/allagents__worktrees/fix-interactive-updated-label/dist/index.js plugin install demo@label-e2e agent-tui run --cwd /tmp/allagents-updated-label-e2e.8deM8Q/workspace env HOME=/tmp/allagents-updated-label-e2e.8deM8Q/home /home/entity/projects/EntityProcess/allagents__worktrees/fix-interactive-updated-label/dist/index.jsIn the TUI, selected
Plugins -> demo@label-e2e -> Update. Observed:No focused test was added because the completion label is inside a private, prompt-driven action with no existing action-level test seam; exporting internals or adding broad prompt mocks would exceed the scope of this copy-only correction. The built-CLI E2E exercises the real interaction instead.
Existing unrelated failures
bun testis not green on the unchanged test surfaces. The pre-push run reported 1,266 passing, 5 skipped, and 54 failing tests across marketplace, user-workspace, user-scope sync, and native marketplace-registration suites. Representative failures includetests/unit/core/marketplace-update.test.ts,tests/unit/core/prune.test.ts, andtests/unit/core/native/native-marketplace-registration.test.ts; none referencesrc/cli/tui/actions/plugins.ts. An earlier full run reported 1,268 passing and 52 failing, consistent with existing shared mock/home-state interference. The push therefore used--no-verifyafter lint, typecheck, focused TUI tests, build, and manual E2E passed.bun test tests/unit/core/marketplace-update.test.tsalso fails in isolation before running tests withSyntaxError: Export named 'cleanupTempDir' not found in module .../src/core/git.ts.bun run test:integrationcannot start because the configured Bats glob points to a missingtests/integrationdirectory:cd: tests/integration: No such file or directory.Post-Deploy Monitoring & Validation
No additional operational monitoring is required because this changes only a terminal completion label and does not alter update or sync behavior. During the next release smoke check, the release owner should run the interactive single-plugin update once and confirm
Updated and synceddoes not appear whileUpdateddoes; any report of the old label is the rollback/mitigation trigger and can be addressed by reverting this commit.