Filter "standing in" regions list by permission access. Fixes #2262#2293
Open
me4502 wants to merge 2 commits into
Open
Filter "standing in" regions list by permission access. Fixes #2262#2293me4502 wants to merge 2 commits into
me4502 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2262 by filtering the list of available regions in "checkRegionStandingIn" by a permission lookup. While leaking the region names isn't much of a big deal, it can be confusing to the user to see a list of regions they do not have access to. This filters the list by what the player can actually use.
Don't need to permission gate global here as it's never displayed to the player, and worst case if returned it'll be hit by the permissions check in the actual command.