Repository navigation
Docking: every view is a dock, and layouts are saved and restored - #4
Merged
Merged
Conversation
The main window now uses Qt Advanced Docking System 5.1.1, as §11 q1 decided. It is fetched by version and SHA-256, built as a shared library (LGPL-2.1-or-later, linked dynamically) and listed in third_party/components.json. Workbench (app/src/workbench.*) places the views and handles layouts: - every view can be moved, split, tabbed, floated and closed; - the layout is saved on close and restored on start; - layouts can be saved by name and opened from View > Layouts; - View > Reset layout brings back the default; - a layout from another layout version is ignored. "Core" and "Core log" are its first two views. tst_workbench checks the rule: no view is fixed, a layout saved is the layout restored in a new window, closed views stay closed, named layouts survive a restart, and reset works. Spec §7 states the layout rule and §9 its test. Linux CI installs libxcb1-dev, which ADS links. The development guide says the first configure downloads ADS. Signed-off-by: teo1747 <148846371+teo1747@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
third_party/components.json, so it appears in the About box's notices.Workbench(app/src/workbench.*) owns the layout:tst_workbenchchecks the rule: no view is fixed, a layout saved is the layout restored in a new window, closed views stay closed, named layouts survive a restart, reset works, and a wrong-version layout is refused.libxcb1-dev(ADS links it). The development guide notes that the first configure downloads ADS.Why
A fully flexible layout is the owner's main requirement. Testing it now, with the first two views, proves it on Windows, Linux and macOS before more views depend on it. ADS 5.x also adds the Wayland support that 4.x lacked.
Not yet
Layouts are kept in the user's settings until projects exist (S1); then they move into the project's
.emblink-studio/(§6).