Repository navigation
tests: hand-run tests target x86_64-elf; a test's own refusal is not a skip - #203
Merged
Merged
Conversation
Since #198 embcc compiles for the host when nothing names a target. tests/run.sh pins x86_64-elf for the suite, but a test run by hand did not get it: on a Mac it built Mach-O objects, and embld-doctor failed for the contributor of #201 although CI passed. tests/lib.sh, which 447 of the 479 golden tests source, now exports it too. target-select builds a TARGETS=arm compiler, which lacks x86_64-elf and refused even --version under the suite's default; it unsets it, as default-target.sh does, and passes both ways. That failure had been reported as a SKIP since #198: run.sh counts a failing test as skipped when its output says "this embcc was built without the X backend", and target-select provokes that message on purpose. A test is now skipped only when X is a family the suite's own compiler lacks ("Not built:" in its --version); on a full build none is. In CI's last run target-select was the only test skipped that way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two test problems left by #198 (the default target is now the host). #201's contributor found the first.
1. Hand-run tests on a Mac built Mach-O.
tests/run.shpinsEMBCC_DEFAULT_TARGET=x86_64-elffor the suite, but a test run on its own (sh tests/golden/embld-doctor.sh) did not get it. On a Mac it compiled foraarch64-apple-darwin, andembld-doctorfailed although CI passed.tests/lib.sh, which 447 of the 479 golden tests source, now exports it as well. In the suite nothing changes: it is the valuerun.shalready sets.2.
target-selecthas been failing in CI since #198, reported as a SKIP.TARGETS=armcompiler. Under the suite'sx86_64-elfdefault, that compiler refused even--version. The test now unsets the default for its own compilers, asdefault-target.shdoes.run.shcounts a failing test as skipped when its output says "this embcc was built without the X backend".target-selectprovokes that message on purpose, so its failure looked like a skip. A test is now skipped only when X is a family the suite's own compiler lacks (theNot built:line of its--version). A full build lacks none.target-selectwas the only test skipped this way.Checked.
embld-doctor,default-targetandtarget-selectpass run by hand withoutEMBCC_DEFAULT_TARGET.target-selectanddefault-targetpass run as the suite runs them.embld-doctorfails by hand without this change.