Fix RPC return errors for psbt and invalid rangeproofs - #1593
Merged
Conversation
tomt1664
changed the title
tomt1664
force-pushed
the
assort_fixes
branch
from
September 1, 2026 12:56
d080768 to
77882b8
Compare
tomt1664
force-pushed
the
assort_fixes
branch
from
September 1, 2026 13:59
77882b8 to
5014fd5
Compare
delta1
reviewed
Sep 1, 2026
tomt1664
force-pushed
the
assort_fixes
branch
from
September 1, 2026 16:12
5014fd5 to
532f9da
Compare
tomt1664
force-pushed
the
assort_fixes
branch
from
September 1, 2026 17:06
532f9da to
a9db3b1
Compare
delta1
approved these changes
Sep 1, 2026
tomt1664
pushed a commit
to tomt1664/elements
that referenced
this pull request
Sep 2, 2026
…d rangeproofs a9db3b1 Add startup warning for signed-blocks parent chain (Tom Trevethan) 246c5ab Add virtual desctructor to CChainParams (Tom Trevethan) 779e71f PAK enforcement on confidential nAsset (Tom Trevethan) ffd91c0 PartiallySignedTransaction::SetupFromTx indexes vtxinwit checked (Tom Trevethan) 84a05e3 check pubkey validity in tweakfedpegscript to prevent assert failure (Tom Trevethan) 3a8dec1 Return error for psbt if explicit amounts/assets deleted (Tom Trevethan) 4e5ca94 Return error for invalid rangproof amounts (Tom Trevethan) Pull request description: Fixes for a number of issues with RPC errors for invalid PSBTs and amounts/rangeproofs. ACKs for top commit: delta1: ACK a9db3b1; tested locally Tree-SHA512: bf35348a5fad30e0f1f2b3caa2ec35ec521b583155e97f3a5f2504a3d70b41677f215fc01b28ccd30706ff5a7d021afb74c110a2c8f270942f5cba344544a55d
tomt1664
added a commit
that referenced
this pull request
Sep 3, 2026
f80fb30 Merge #1589: simplicity: update subtree to abede47e (merge-script) 5b388c2 Merge pull request #1577 from Abdullah1738/feat/effective-fee-asset (Tom Trevethan) 48456e3 Add test that sighash midstate cache treats the SIGHASH_RANGEPROOF bit as part of its key (Tom Trevethan) d47af63 Merge #1584: script: add and default to SIGHASH_ALL_WITH_RANGEPROOF for pre-taproot signing (merge-script) 7c23bd1 blind: reject empty surjection-target set in SurjectOutput (Byron Hambly) 3e11e03 blindpsbt: require genuine commitments in VerifyBlindValueProof (Byron Hambly) 99e9f25 blindpsbt: require both range bounds to match claim in VerifyBlindValueProof (Byron Hambly) 8a08453 validation: always validate and retain dynafed header block_height (Byron Hambly) 4309282 dynafed: require at least four-fifths approval for parameter transition (Byron Hambly) 6a49991 blindpsbt: refuse to blind a PSET output with no amount (Byron Hambly) 0ce3c24 blindpsbt: reject off-curve blinding pubkey before ECDH (Byron Hambly) 2391041 blindpsbt: return error instead of asserting on surjection proof failure (Byron Hambly) 6253d7e fix: range proof cache bind to asset and scriptpubkey (Byron Hambly) 3d7134f Merge #1593: Fix RPC return errors for psbt and invalid rangeproofs (merge-script) Pull request description: ACKs for top commit: delta1: ACK f80fb30; tested locally Tree-SHA512: 42995e5b4842ce9694d9d5d30764230b774db24cda40d825742a174d564761e725a8323362404ee9653495936ab850c9933075b7ad924caa73768d0980bcbf96
psgreco
pushed a commit
to psgreco/elements
that referenced
this pull request
Sep 3, 2026
…d rangeproofs a9db3b1 Add startup warning for signed-blocks parent chain (Tom Trevethan) 246c5ab Add virtual desctructor to CChainParams (Tom Trevethan) 779e71f PAK enforcement on confidential nAsset (Tom Trevethan) ffd91c0 PartiallySignedTransaction::SetupFromTx indexes vtxinwit checked (Tom Trevethan) 84a05e3 check pubkey validity in tweakfedpegscript to prevent assert failure (Tom Trevethan) 3a8dec1 Return error for psbt if explicit amounts/assets deleted (Tom Trevethan) 4e5ca94 Return error for invalid rangproof amounts (Tom Trevethan) Pull request description: Fixes for a number of issues with RPC errors for invalid PSBTs and amounts/rangeproofs. ACKs for top commit: delta1: ACK a9db3b1; tested locally Tree-SHA512: bf35348a5fad30e0f1f2b3caa2ec35ec521b583155e97f3a5f2504a3d70b41677f215fc01b28ccd30706ff5a7d021afb74c110a2c8f270942f5cba344544a55d (cherry picked from commit 3d7134f)
delta1
added a commit
that referenced
this pull request
Sep 6, 2026
6c2c562 build: fix depends Qt download link (Pablo Greco) 3c8b453 Merge #1593: Fix RPC return errors for psbt and invalid rangeproofs (merge-script) 45af24e DecomposePeginWitness: fix deserialization flags for MerkleBlock proof (Byron Hambly) 60488fa Merge #1589: simplicity: update subtree to abede47e (merge-script) f1f9a3f blind: reject empty surjection-target set in SurjectOutput (Byron Hambly) 11f8ac6 blindpsbt: require genuine commitments in VerifyBlindValueProof (Byron Hambly) db05523 blindpsbt: require both range bounds to match claim in VerifyBlindValueProof (Byron Hambly) 6257051 dynafed: require at least four-fifths approval for parameter transition (Byron Hambly) 53302be blindpsbt: refuse to blind a PSET output with no amount (Byron Hambly) dd97f13 blindpsbt: reject off-curve blinding pubkey before ECDH (Byron Hambly) 87327c7 blindpsbt: return error instead of asserting on surjection proof failure (Byron Hambly) 212c43f fix: range proof cache bind to asset and scriptpubkey (Byron Hambly) Pull request description: All clean cherry picks from 23.x branch, in preparation for 23.3.4rc2 ACKs for top commit: tomt1664: ACK 6c2c562 tested locally delta1: ACK 6c2c562 Tree-SHA512: 54129b93b1ce801dea0c427d69f74ada53df3584f9e4d05eaea70d0040cf28db9c36a83dd42d40a48031747bf757d27a316f8d7b88fb97756b6e4acd777f601e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for a number of issues with RPC errors for invalid PSBTs and amounts/rangeproofs.