Repository navigation
Replace current expression.rs module with calls to the rust-miniscript's expression module - #112
Conversation
|
See https://github.com/KyrylR/elements-miniscript/blob/298f2bc0eb8ef82876fe60fbe5f7e03a5a8258ff/CHANGELOG.md for the short description of changes |
20b073d to
2c5ed14
Compare
2c5ed14 to
d65bcdd
Compare
d65bcdd to
4540de0
Compare
|
As discussed in the #108, this is a second step in revising simplicity descriptors |
|
In 4bef5c4: Fine to keep |
| // eltr is parsed without extensions first, and then with the extension | ||
| // type T. Tr::from_str will check the checksum | ||
| // match "tr(" to handle more extensibly | ||
| let desc = if s.starts_with(&format!("{}tr", ELMTS_STR)) { |
There was a problem hiding this comment.
In 4bef5c4:
This is also okay to leave in for this PR but we should be able to rip out all these string-parsing and "try multiple parses in a row" junk.
|
Taking a look for both comments today |
|
The |
f652baf psbt: clear the output tap tree for key-only descriptors (Kyryl R) Pull request description: #112 should be merged first Before this change, replacing an output's descriptor with a key-path-only eltr(K) left any previously written tree in place. The output would then advertise a script tree that its own internal key and script_pubkey no longer commit to. Upstream [rust-miniscript](https://git.rust-bitcoin.org/rust-bitcoin/rust-miniscript/) reached the same behaviour by a different route. Its master branch now writes `*tap_tree = spend_info.to_tap_tree();` unconditionally, and `to_tap_tree` returns None when the tree is empty (`src/descriptor/tr/spend_info.rs`, merged in [PR #815](https://git.rust-bitcoin.org/rust-bitcoin/rust-miniscript/pulls/815)) ACKs for top commit: apoelstra: ACK f652baf; successfully ran local tests; though in future please split the unit test into a separate commit Tree-SHA512: 7ba074a22d4f58f6922ca0f151e004bd798aebb1e99299d248f39058634f7e3fa903d41f01a7f596eb82fc4b98636b479acc88490e9166c19b6c7751f04b2cd2
Built upon the #110
The #110 should be merged first