Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/strict-cookie-names.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"effect": patch
---

Ignore `Set-Cookie` headers whose cookie names do not satisfy the RFC 6265 token syntax.
2 changes: 1 addition & 1 deletion packages/effect/src/unstable/http/Cookies.ts
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ function parseSetCookie(header: string): Cookie | undefined {
return undefined
}
const name = parts[0].slice(0, firstEqual)
if (!fieldContentRegExp.test(name)) {
if (!cookieNameRegExp.test(name)) {
return undefined
}

Expand Down
12 changes: 12 additions & 0 deletions packages/effect/test/unstable/http/Cookies.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,18 @@ describe("Cookies", () => {
})
})

describe("fromSetCookie", () => {
it("ignores invalid cookie names", () => {
const cookies = Cookies.fromSetCookie([
"bad name=value",
"session=abc"
])

assertNone(Cookies.get(cookies, "bad name"))
assertSome(Cookies.getValue(cookies, "session"), "abc")
})
})

describe("toSetCookieHeaders", () => {
const invalidCookie = {
name: "session",
Expand Down