Add FileSystem.lstat support - #6428
Draft
coyaSONG wants to merge 2 commits into
Draft
Conversation
tim-smart
added
the
enhancement
ChatGPT Codex Connector
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
# Conflicts: # packages/platform-node-shared/test/NodeFileSystem.test.ts
🦋 Changeset detectedLatest commit: 79679f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
Add
FileSystem.lstatso callers can inspect a path without following symbolic links. The shared Node-compatible implementation delegates tonode:fs.lstat, reuses the existingFile.Infoconversion, and is available to both the Node and Bun platform layers.FileSystem.statfollows a symbolic link and reports information about its target, so Effect callers currently have to leave the portableFileSystemservice to distinguish a link from a file or directory. The regression creates a file and symbolic link, verifies thatstatreports the target as a file, and verifies thatlstatreports the link asSymbolicLink.The change also adds the corresponding no-op test implementation and a patch changeset for
effectand@effect/platform-node-shared.OpenAI Codex assisted with the implementation and command execution. No human review is claimed.
Validation:
corepack pnpm test packages/platform-node-shared/test/NodeFileSystem.test.tsfailed only becausefs.lstatwas absent; the final focused suite passes 10/10.corepack pnpm lint-fixcorepack pnpm checkgit diff --checkRelated