Repository navigation
Conversation
EduPage now sends vsetkyZnamky[].udalostid as a number, while the keys of vsetkyUdalosti["edupage"] are strings, so every lookup returned None and get_grades() raised AttributeError. Cast the id to str before the lookup, and skip a grade whose event details are missing instead of failing the whole call. Fixes EdupageAPI#134
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #134.
EduPage now returns
vsetkyZnamky[].udalostidas a number, while the keys ofvsetkyUdalosti["edupage"]are still strings.get_grades()therefore found no event details and raisedAttributeError: 'NoneType' object has no attribute 'get'on every call.Changes in
get_grades():udalostidtostrbefore the details lookup;Tests: two new cases in
tests/test_grades.py(numericudalostid, grade without event details). Both fail on current master and pass with this change; the full suite passes (50 tests). Also checked against live data from a parent account (two students): all grades load again.