Wire swaps.xyz swap provider - #6128
Draft
j0ntz wants to merge 1 commit into
Draft
Conversation
Add SWAPSXYZ_INIT core plugin init (envConfig) and register the swapsxyz swap plugin in corePlugins so the app initializes the new edge-exchange-plugins swaps.xyz provider from env.json SWAPSXYZ_INIT.apiKey. Requires a published edge-exchange-plugins containing the swapsxyz plugin plus a dependency bump before it is functional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
Depends on EdgeApp/edge-exchange-plugins#480 (the swaps.xyz plugin). This PR is a draft until that PR merges, edge-exchange-plugins publishes a version containing the
swapsxyzplugin, and this branch bumpsedge-exchange-pluginsto it.Requirements
No visual changes (env/config wiring only).
Description
Wire the new swaps.xyz swap provider so the app initializes it:
src/envConfig.ts— addSWAPSXYZ_INITcore plugin init (apiKey).src/util/corePlugins.ts— registerswapsxyz: ENV.SWAPSXYZ_INITinswapPlugins.The runtime key is supplied via
env.jsonSWAPSXYZ_INIT.apiKey. With a published edge-exchange-plugins containing the plugin, the app then offers swaps.xyz quotes.Verified in-app on the iOS sim (with the plugin linked via updot and the key in env.json): a real Base ETH → USDC swap executed through swaps.xyz to the success scene. Evidence is attached to the plugin PR EdgeApp/edge-exchange-plugins#480.
Asana: https://app.asana.com/0/1215088146871429/1217036054017879