Repository navigation
fix: shifted punctuation and the wubi-code hint (ADR-337) - #274
Merged
Merged
Conversation
…-code hint (ADR-337) Typing 12:30 produced 12;30 because the core received ; instead of :. The host now computes the typed character from the key code with Shift applied. The wubi-code hint did not appear on a real device; it now judges against a snapshot taken before the commit and logs every branch to the HUD diagnostic log, since the root cause is not yet known. Signed-off-by: wangzhizhou <824219521@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
用户在候选
3e428b7上的实机反馈:12:30得到12;30。改动
typedScalar,用characters(byApplyingModifiers:)按键码 + Shift 计算本次按键的字符,不再直接用charactersIgnoringModifiers。:?<等到达核心时就是它们自己。shownCandidates;提示路径每个分支在诊断开关打开时写日志(hint skip=…/hint show=…)。需要说明的不确定性
charactersIgnoringModifiers为何是未加 Shift 的字符)没有在真机上单独验证,修复方式对两种情况都成立。验证
make verifyPASSmake macos-offline-tests:62 文件 / 328 例 PASS(test-controller-menu.py新增 6 条 Shift 取字符断言)build.sh --strictPASS