Repository navigation
fix(site): keep site credentials out of the log - #244
Merged
Merged
Conversation
The generated or given database, database root and admin passwords are registered with EE::obfuscate() when core provides it, so they are masked in every logged command and its output. The error for a weak --admin-pass no longer repeats the password, and 'ee site info --format=json' prints the site row without writing it to the log.
The logs directory is now created readable by root only, so the log output step reads it with sudo.
There was a problem hiding this comment.
🟡 Changes recommended
Supplied passwords are logged before obfuscation is registered.
1 open finding
What changed in this PR
Prevents WordPress site credentials from being exposed through logs.
Changes:
- Masks generated credentials and removes passwords from errors.
- Sends JSON site information only to standard output.
- Reads CI logs with elevated permissions.
| File | Description |
|---|---|
src/WordPress.php |
Reduces credential exposure in output and logs. |
.github/workflows/test_and_build.yml |
Reads protected logs using sudo. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mrrobot47
added a commit
to mrrobot47/site-type-wp
that referenced
this pull request
Oct 19, 2026
…lias CACHE-1, WP-1 and SEC-1 scenarios are regular; the weak password message no longer echoes the password (EasyEngine#244); the wildcard refusal runs on a site that never had SSL, since one that had --ssl=self keeps site_ssl_wildcard=1 and goes on to request a certificate; the new alias is polled until the proxy serves it (PRX-7).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated or given database and admin passwords are registered for masking (when core provides it),
site info --format=jsonno longer writes to the log, and the weak-password error no longer repeats the password. CI reads the logs with sudo.