fix(mariadb): disable binary logs by default#342
Open
mrrobot47 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Disables MariaDB binary logging by default in the EasyEngine MariaDB image by removing EasyEngine’s explicit binlog configuration from mariadb/ee.cnf, preventing unbounded growth of persisted mariadb-bin.* files on non-replication installs.
Changes:
- Removed
log_bin,log_bin_index,binlog_format,expire_logs_days, andmax_binlog_sizedefaults frommariadb/ee.cnf. - Kept the
[mysqld]section so the config file remains syntactically valid.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
log_bin,log_bin_index,binlog_format,expire_logs_days, andmax_binlog_sizesettings frommariadb/ee.cnf.[mysqld]section so the config file remains valid.Why
EasyEngine does not configure or manage MariaDB replication for the global DB. Enabling binary logs by default causes persisted
mariadb-bin.*files to grow without a practical total disk cap.max_binlog_sizeonly rotates individual files, andexpire_logs_daysonly purges by age during specific server events. High-write installs can still fill disk.Notes
skip-log-binis intentionally not added. Removing EasyEngine's defaultlog_binkeeps binlogging off by default without overriding users who deliberately enable binlogs elsewhere.