fix(http) request->abort() was not firing onDisconnect() - #458
Closed
mathieucarbou wants to merge 2 commits into
Closed
fix(http) request->abort() was not firing onDisconnect()#458mathieucarbou wants to merge 2 commits into
mathieucarbou wants to merge 2 commits into
Conversation
mathieucarbou
changed the title
me-no-dev
approved these changes
Jul 20, 2026
mathieucarbou
force-pushed
the
fix/onDisconnect
branch
from
July 20, 2026 11:16
c8a634f to
7097ab1
Compare
mathieucarbou
marked this pull request as draft
July 20, 2026 13:27
Member
Author
|
Member
Author
|
@me-no-dev @willmmiles : I am extracting in another PR (#459) the re-ordering that I will merge once #459 passes in order to leave in this PR only the |
mathieucarbou
force-pushed
the
fix/onDisconnect
branch
from
July 20, 2026 14:03
7097ab1 to
aa4267b
Compare
Member
Author
|
I am closing this PR. As I commented here: ESP32Async/AsyncTCP#118 (comment) onDisconnect was indeed called. Currently, it is called from the async task when the error event is processed (which can lead to a use after free). PR ESP32Async/AsyncTCP#118 proposes to remove this use after free and process the callback during the abort call in the caller thread, exactly like it is done for close. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.