Repository navigation
Stop rapid rot cycles when world generation refuses every write - #1230
Open
BonsUnleashed wants to merge 1 commit into
Open
BonsUnleashed wants to merge 1 commit into
BonsUnleashed wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During world generation, a region can refuse a branch removal while continuing to return that branch from reads.
Species.rotstill reports success, so rapid rot can recurse between neighbouring branches until the stack overflows.This tracks active rot checks and successful branch removals and post-rot placements. It stops a repeated check only when no rot write has succeeded since the earlier check. Cascades that make progress can revisit positions. Both branch and root methods use
finallycleanup, including when a recursive call throws.The guard is limited to the exact
WorldGenRegionimplementation. Other level accessors and custom branch, species or feature code keep the original path. This follows the refused-write guard prepared for Bons and Furious 1.0.30.compileJavapassed against the currentrelease/1.20.1branch on Java 17.Checks using the actual guard and extracted native call bodies passed refused writes, successful revisits, partially writable regions, custom/fertility fallbacks, exception cleanup and subsequent direct calls. Minecraft dependencies were stubbed. The failure is related to #1150; I have not tested this build in the reporter's world.