Repository navigation
Conversation
maartenba
requested review from
Erwinvandervalk,
ProgrammerAL,
josephdecock,
khalidabuhakmeh and
wcabus
November 9, 2026 09:33
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new list in client-assertions.mdx uses - bullets instead of the * markers explicitly required by the documentation guidelines.
1 open issue
What changed in this PR
This documentation update clarifies RFC 10070 client assertion requirements across IdentityServer and related client libraries, including version-specific validation behavior and rollout guidance.
Changes:
- Documents issuer-only audiences, JWT type headers, and IdentityServer v7/v8 differences.
- Updates client assertion examples and corrects authentication request parameters.
- Clarifies FAPI 2.0 constraints and guidance against SAML client assertions in new applications.
| File | Description |
|---|---|
| astro/src/content/docs/introspection/events.mdx | Updates the example to use a configured issuer audience. |
| astro/src/content/docs/identityserver/upgrades/v7_4-to-v8_0.md | Clarifies option migration, array support, and rollout guidance. |
| astro/src/content/docs/identityserver/tokens/par.md | Adds issuer-audience guidance for PAR authentication. |
| astro/src/content/docs/identityserver/tokens/fapi-2-0-specification.mdx | Adds strict-validation configuration and FAPI caveats. |
| astro/src/content/docs/identityserver/tokens/client-authentication.md | Corrects request parameters and explains validation behavior. |
| astro/src/content/docs/identityserver/reference/v8/options.md | Expands strict-validation option documentation. |
| astro/src/content/docs/identityserver/reference/v7/options.md | Updates RFC references and header requirements. |
| astro/src/content/docs/identityserver/overview/specs.md | Lists partial RFC 10070 support. |
| astro/src/content/docs/identitymodel/utils/constants.md | Warns against new SAML client-authentication usage. |
| astro/src/content/docs/identitymodel/endpoints/client-assertions.mdx | Adds audience, type-header, and SAML guidance. |
| astro/src/content/docs/accesstokenmanagement/advanced/client-assertions.mdx | Clarifies audience comments and adds RFC and vulnerability links. |
Review effort: Balanced
Correct formatting and remove duplicate lines regarding issuer identifier and typ header. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
khalidabuhakmeh
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.