Skip to content

[STACKED on #964] fix(mock-attestation): model complete DCAP collateral #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kvinwang wants to merge 3 commits into
base: codex/feat-simulator-seeded-attestation
Choose a base branch
from
Open

[STACKED on #964] fix(mock-attestation): model complete DCAP collateral #965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de898d2
fix(mock-attestation): serve legacy DCAP paths
kvinwang Jul 29, 2026
a96d311
fix(mock-attestation): model the PCK CA chain
kvinwang Jul 29, 2026
1c9d6f7
fix(mock-attestation): serve the PCK issuer CRL
kvinwang Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions dstack/crates/mock-attestation/src/server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,10 @@ pub fn router(state: Arc<MockCollateralState>) -> Router {
Router::new()
.route("/sgx/certification/v4/pckcrl", get(pck_crl))
.route("/sgx/certification/v4/rootcacrl", get(pccs_root_crl))
// Older guest images use the SGX PCS prefix for shared DCAP collateral.
// Serve both spellings so simulated TDX evidence remains compatible.
.route("/sgx/certification/v4/tcb", get(tcb_info))
.route("/sgx/certification/v4/qe/identity", get(qe_identity))
.route("/tdx/certification/v4/tcb", get(tcb_info))
.route("/tdx/certification/v4/qe/identity", get(qe_identity))
.route("/vcek/v1/Milan/cert_chain", get(sev_ca_chain))
Expand Down Expand Up @@ -90,8 +94,11 @@ async fn pccs_root_crl(State(state): State<Arc<MockCollateralState>>) -> impl In

async fn pck_crl(State(state): State<Arc<MockCollateralState>>) -> impl IntoResponse {
binary(
state.tdx.root_crl_der(),
Some(("SGX-PCK-CRL-Issuer-Chain", state.tdx.root_ca_pem())),
state.tdx.pck_crl_der(),
Some((
"SGX-PCK-CRL-Issuer-Chain",
state.tdx.sample_collateral().unwrap().pck_crl_issuer_chain,
)),
)
}

Expand Down
79 changes: 62 additions & 17 deletions dstack/crates/mock-attestation/src/tdx.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,17 @@
// SPDX-License-Identifier: Apache-2.0

use anyhow::Result;
use dcap_qvl::QuoteCollateralV3;
use dcap_qvl::quote::{
AuthData, AuthDataV4, CertificationData, Data, EnclaveReport, Header,
QEReportCertificationData, Quote, Report, TDReport10,
};
use p256::ecdsa::{Signature, SigningKey, signature::Signer};
use dcap_qvl::QuoteCollateralV3;
use p256::ecdsa::{signature::Signer, Signature, SigningKey};
use p256::pkcs8::{DecodePrivateKey, EncodePrivateKey};
use rcgen::{
BasicConstraints, Certificate, CertificateParams, CertificateRevocationListParams,
CertifiedKey, CustomExtension, DnType, ExtendedKeyUsagePurpose, IsCa, KeyIdMethod, KeyPair,
KeyUsagePurpose, PKCS_ECDSA_P256_SHA256, RemoteKeyPair, SerialNumber, SignatureAlgorithm,
KeyUsagePurpose, RemoteKeyPair, SerialNumber, SignatureAlgorithm, PKCS_ECDSA_P256_SHA256,
};
use scale::Encode;
use serde_json::json;
Expand All @@ -30,8 +30,10 @@ const INTEL_QE_VENDOR_ID: [u8; 16] = [
pub struct TdxGenerator {
root: Certificate,
root_signing_key: SigningKey,
pck_ca: Certificate,
pck: Certificate,
pck_key: SigningKey,
pck_crl: Vec<u8>,
tcb_signer: Certificate,
tcb_signer_key: SigningKey,
qe_signer: Certificate,
Expand Down Expand Up @@ -88,12 +90,19 @@ impl TdxGenerator {
},
root_signing_key,
) = make_root(&seed)?;
let (pck_ca, pck_ca_key) = make_ca(
"Mock Intel SGX PCK Platform CA",
"tdx-pck-ca",
&seed,
&root,
&root_key,
)?;
let (pck, pck_key) = make_leaf(
"Mock Intel SGX PCK Certificate",
"tdx-pck",
&seed,
&root,
&root_key,
&pck_ca,
&pck_ca_key,
true,
)?;
let (tcb_signer, tcb_signer_key) = make_leaf(
Expand All @@ -112,6 +121,17 @@ impl TdxGenerator {
&root_key,
false,
)?;
let pck_crl = CertificateRevocationListParams {
this_update: fixed_time(MOCK_PKI_NOT_BEFORE)?,
next_update: fixed_time(MOCK_PKI_NOT_AFTER)?,
crl_number: SerialNumber::from(1u64),
issuing_distribution_point: None,
revoked_certs: Vec::new(),
key_identifier_method: KeyIdMethod::Sha256,
}
.signed_by(&pck_ca, &pck_ca_key)?
.der()
.to_vec();
let root_crl = CertificateRevocationListParams {
this_update: fixed_time(MOCK_PKI_NOT_BEFORE)?,
next_update: fixed_time(MOCK_PKI_NOT_AFTER)?,
Expand All @@ -126,8 +146,10 @@ impl TdxGenerator {
Ok(Self {
root,
root_signing_key,
pck_ca,
pck,
pck_key,
pck_crl,
tcb_signer,
tcb_signer_key,
qe_signer,
Expand Down Expand Up @@ -157,6 +179,10 @@ impl TdxGenerator {
self.root_crl.clone()
}

pub fn pck_crl_der(&self) -> Vec<u8> {
self.pck_crl.clone()
}

pub fn attest(&self, report_data: [u8; 64]) -> Result<TdxEvidence> {
self.attest_with_rtmrs(
report_data,
Expand Down Expand Up @@ -207,7 +233,8 @@ impl TdxGenerator {
.map_err(|bytes: Vec<u8>| anyhow::anyhow!("invalid QE report size {}", bytes.len()))?;
let qe_sig: Signature = self.pck_key.sign(&qe_report_bytes);

let pck_chain = format!("{}{}", self.pck.pem(), self.root.pem()).into_bytes();
let pck_chain =
format!("{}{}{}", self.pck.pem(), self.pck_ca.pem(), self.root.pem()).into_bytes();
let qe_certification = QEReportCertificationData {
qe_report: qe_report_bytes,
qe_report_signature: qe_sig.to_bytes().into(),
Expand Down Expand Up @@ -287,9 +314,9 @@ impl TdxGenerator {
"isvprodid":1, "tcbLevels":[{"tcb":{"isvsvn":1},"tcbDate":issue,"tcbStatus":"UpToDate"}]
}).to_string();
Ok(QuoteCollateralV3 {
pck_crl_issuer_chain: self.root.pem(),
pck_crl_issuer_chain: format!("{}{}", self.pck_ca.pem(), self.root.pem()),
root_ca_crl: self.root_crl.clone(),
pck_crl: self.root_crl.clone(),
pck_crl: self.pck_crl.clone(),
tcb_info_issuer_chain: format!("{}{}", self.tcb_signer.pem(), self.root.pem()),
tcb_info_signature: sign_raw(&self.tcb_signer_key, tcb_info.as_bytes())?,
tcb_info,
Expand Down Expand Up @@ -322,6 +349,25 @@ fn make_root(seed: &[u8; 32]) -> Result<(CertifiedKey, SigningKey)> {
Ok((CertifiedKey { cert, key_pair }, signing_key))
}

fn make_ca(
name: &str,
label: &str,
seed: &[u8; 32],
issuer: &Certificate,
issuer_key: &KeyPair,
) -> Result<(Certificate, KeyPair)> {
let (key, _) = deterministic_key_pair(seed, label)?;
let mut params = cert_params(name)?;
params.is_ca = IsCa::Ca(BasicConstraints::Unconstrained);
params.key_usages.extend([
KeyUsagePurpose::DigitalSignature,
KeyUsagePurpose::KeyCertSign,
KeyUsagePurpose::CrlSign,
]);
let cert = params.signed_by(&key, issuer, issuer_key)?;
Ok((cert, key))
}

fn make_leaf(
name: &str,
label: &str,
Expand Down Expand Up @@ -446,14 +492,13 @@ mod tests {
);
let mut tampered = evidence.quote.clone();
tampered[100] ^= 1;
assert!(
verifier
.verify(&tampered, &evidence.collateral, now)
.is_err()
);
assert!(
crate::ensure_report_data(&verified.report.as_td10().unwrap().report_data, &[0x24; 64])
.is_err()
);
assert!(verifier
.verify(&tampered, &evidence.collateral, now)
.is_err());
assert!(crate::ensure_report_data(
&verified.report.as_td10().unwrap().report_data,
&[0x24; 64]
)
.is_err());
}
}