fix(gateway): saturate certificate lock expiry - #1015
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the gateway’s KV-based ACME lease/lock handling by preventing u64 overflow when computing lock expiry times, ensuring locks don’t accidentally appear expired (or panic in debug/checked builds).
Changes:
- Use
saturating_addwhen computing certificate-renewal and ACME-rotation lock expiry. - Add a regression test that writes a lock with
started_at = u64::MAXand asserts acquisition correctly fails (lock remains held).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent overflow while calculating expiry for certificate-renewal and ACME-rotation leases. Saturating addition preserves a far-future lock instead of panicking in checked builds or wrapping to an expired timestamp.
Verification
cargo fmt --all -- --checkcargo test -p dstack-gateway lease_expiry_does_not_overflow -- --nocapturegit diff --check