fix(do-7299): replace mamezou-tech/setup-helmfile with arch-aware binary download - #1
Merged
Conversation
…ary download mamezou-tech/setup-helmfile hardcodes linux_amd64 in its JS source and has no arm64 support. Replace with a shell step that detects arch via uname -m and downloads the correct helmfile binary from the official helmfile GitHub Releases. Helm is already installed by azure/setup-helm in the dw-github-workflows wrapper (argocd-deploy/action.yml) before this action is invoked, so helm-version input is intentionally unused here.
bd16ells
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces
mamezou-tech/setup-helmfile@v2.2.0with a shell step that detects arch viauname -mand downloads the correct helmfile binary from GitHub Releases.Files changed
action.yml— core change: replace mamezou step with arch-aware binary download.github/CODEOWNERS— DriveWealth org requirement (* @DriveWealth/devops)Why
mamezou-tech/setup-helmfilehardcodeslinux_amd64in its JS installers with no ARM64 support. The official helmfile project shipslinux_arm64binaries and cloudposse does not expose mamezou'shelm-download-urlinput to allow overriding from outside.Helm itself is already installed by
azure/setup-helmin thedw-github-workflowswrapper (argocd-deploy/action.yml) before this action is called, so only the helmfile binary needs to be installed here.Note
The integration tests (
test-helmfile-raw.yml, etc.) requireDOCKERHUB_USERNAME/DOCKERHUB_PASSWORDsecrets and a live Kubernetes cluster — these are not available in this fork. The upstream tests pass on the cloudposse repo. CI failures here are pre-existing and unrelated to this change.How to use in dw-github-workflows
After merging, replace the reference in
.github/actions/argocd-deploy/action.yml:Also remove the stale AMD64-only
runs-onpins and comments from:cd-preview-argocd.yamlcommon-argocd-app-release.yamlcommon-argocd-app-rollback.yamlReferences
linux_amd64)Checklist
action.ymlupdatedx86_64→amd64,aarch64→arm64helmfile-versioninput threaded through (strips leadingvbefore URL construction)