Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/diagrams/generated/_index.json

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions docs/diagrams/generated/_overview.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ kind: overview
codebase: visioncraft
---
# visioncraft overview
10 files · 182 symbols · 691 relations · 90 flows · 583 calls
10 files · 184 symbols · 692 relations · 90 flows · 586 calls

## crates
```mermaid
Expand Down Expand Up @@ -32,7 +32,7 @@ flowchart LR
visioncraft -->|"11"| io
visioncraft -->|"32"| nix
visioncraft -->|"7"| recorded
visioncraft -->|"37"| sealmap_corpus
visioncraft -->|"38"| sealmap_corpus
visioncraft -->|"14"| serde
visioncraft -->|"20"| serde_json
visioncraft -->|"3"| sha2
Expand Down
29 changes: 23 additions & 6 deletions docs/diagrams/generated/src/plan.rs.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ sealmap: 2
source: src/plan.rs
module: "sym:cargo visioncraft . plan/"
language: rust
source_hash: blake3:a0eaf6b6e34139a3b02ddc3d521d69dc4c064884b96dfe85585b1a1e7da2107d
lines: 413
fragments: 4
source_hash: blake3:0c39b973a72d258d18a489bd487d5fea34804216b30f2f4f3f1816a6a3667fc7
lines: 425
fragments: 5
---
# `sym:cargo visioncraft . plan/` · src/plan.rs
> Typed plans describe explicitly selected checks; parsing never runs them.
Expand Down Expand Up @@ -92,6 +92,8 @@ classDiagram
<<module>>
+const MAX_PLAN_CHECKS: usize
+const MAX_PLAN_DURATION_MS: u64
+const MAX_PLAN_EXPECTATIONS: usize
+const MAX_PLAN_INPUTS: usize
+const MAX_PLAN_OUTPUT_BYTES: u64
~same_inputs(crate) bool
~validate_input_paths(crate) Result#lt;#40;#41;, ContractError#gt;
Expand Down Expand Up @@ -120,7 +122,7 @@ classDiagram
```

## `sym:cargo visioncraft . plan/Subject#validate().`
`pub fn validate(&self) -> Result<(), ContractError>` · L36-L58
`pub fn validate(&self) -> Result<(), ContractError>` · L40-L62
> Check identity, dirty-snapshot and unique input-path requirements.
```mermaid
sequenceDiagram
Expand All @@ -140,8 +142,22 @@ sequenceDiagram
visioncraft__plan___tSubject->>visioncraft__plan: validate_inputs(&self.inputs)
```

## `sym:cargo visioncraft . plan/validate_inputs().`
`pub(crate) fn validate_inputs(inputs: &[Artifact]) -> Result<(), ContractError>` · L65-L72
```mermaid
sequenceDiagram
participant visioncraft__plan as plan mod
participant _sealmap_corpus as sealmap_corpus ext
participant visioncraft as visioncraft mod
visioncraft__plan->>_sealmap_corpus: Artifact::is_empty()
visioncraft__plan->>visioncraft: require(_, #quot;subject inpu…)?
visioncraft__plan->>_sealmap_corpus: Artifact::len()
visioncraft__plan->>visioncraft: require(_, #quot;subject inpu…)?
visioncraft__plan->>visioncraft__plan: validate_input_paths(inputs)
```

## `sym:cargo visioncraft . plan/Invocation#validate().`
`pub fn validate(&self) -> Result<(), ContractError>` · L104-L137
`pub fn validate(&self) -> Result<(), ContractError>` · L112-L145
> Validate the bounded argv contract without resolving executables or env.
```mermaid
sequenceDiagram
Expand All @@ -161,7 +177,7 @@ sequenceDiagram
```

## `sym:cargo visioncraft . plan/QualityPlan#validate().`
`pub fn validate(&self) -> Result<(), ContractError>` · L291-L398
`pub fn validate(&self) -> Result<(), ContractError>` · L299-L410
> Validate identifiers, references and bounded execution policies.
```mermaid
sequenceDiagram
Expand All @@ -170,6 +186,7 @@ sequenceDiagram
participant visioncraft__plan___tSubject as Subject
visioncraft__plan___tQualityPlan->>visioncraft: require(_, #quot;unsupported …)?
visioncraft__plan___tQualityPlan->>visioncraft: require(_, #quot;plan check c…)?
visioncraft__plan___tQualityPlan->>visioncraft: require(_, #quot;plan expecta…)?
visioncraft__plan___tQualityPlan->>visioncraft: identifier(&self.id)
visioncraft__plan___tQualityPlan->>visioncraft: require(identifier(), #quot;invalid plan…)?
visioncraft__plan___tQualityPlan->>visioncraft__plan___tSubject: validate()?
Expand Down
12 changes: 12 additions & 0 deletions src/plan.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ use std::collections::BTreeSet;

/// Maximum number of declared checks, including optional checks, in one plan.
pub const MAX_PLAN_CHECKS: usize = 1024;
/// Maximum number of declared behavioural expectations in one plan.
pub const MAX_PLAN_EXPECTATIONS: usize = 4096;
/// Maximum number of selected subject input files in one plan.
pub const MAX_PLAN_INPUTS: usize = 16_384;
/// Maximum sum of declared command deadlines: one day, excluding bounded cleanup.
pub const MAX_PLAN_DURATION_MS: u64 = 86_400_000;
/// Maximum sum of declared stdout/stderr capture bounds: one GiB per plan.
Expand Down Expand Up @@ -60,6 +64,10 @@ impl Subject {

pub(crate) fn validate_inputs(inputs: &[Artifact]) -> Result<(), ContractError> {
require(!inputs.is_empty(), "subject inputs cannot be empty")?;
require(
inputs.len() <= MAX_PLAN_INPUTS,
"subject input count exceeds admission ceiling",
)?;
validate_input_paths(inputs)
}

Expand Down Expand Up @@ -298,6 +306,10 @@ impl QualityPlan {
self.checks.len() <= MAX_PLAN_CHECKS,
"plan check count exceeds admission ceiling",
)?;
require(
self.expectations.len() <= MAX_PLAN_EXPECTATIONS,
"plan expectation count exceeds admission ceiling",
)?;
require(identifier(&self.id), "invalid plan id")?;
self.subject.validate()?;
require(
Expand Down
40 changes: 40 additions & 0 deletions tests/core.rs
Original file line number Diff line number Diff line change
Expand Up @@ -753,3 +753,43 @@ fn valid_individual_checks_cannot_form_an_unbounded_aggregate_plan() {
"required and optional checks share admission limits"
);
}

#[test]
fn selected_inputs_and_expectations_have_admission_ceilings() {
let mut p = plan();
// plan() already selects one input, so MAX_PLAN_INPUTS - 1 more reach the ceiling.
for n in 1..visioncraft::plan::MAX_PLAN_INPUTS {
p.subject
.inputs
.push(artifact(&format!("gen/{n}.rs"), b"fn g() {}"));
}
assert!(
p.validate().is_ok(),
"exact selected-input ceiling remains usable"
);
p.subject
.inputs
.push(artifact("gen/extra.rs", b"fn e() {}"));
assert!(
p.validate().is_err(),
"selected inputs cannot exceed the admission ceiling"
);

let mut p = plan();
for n in 0..visioncraft::plan::MAX_PLAN_EXPECTATIONS {
let mut e = expectation();
e.id = format!("exp-{n}");
p.expectations.push(e);
}
assert!(
p.validate().is_ok(),
"exact expectation ceiling remains usable"
);
let mut overflow = expectation();
overflow.id = format!("exp-{}", visioncraft::plan::MAX_PLAN_EXPECTATIONS);
p.expectations.push(overflow);
assert!(
p.validate().is_err(),
"declared expectations cannot exceed the admission ceiling"
);
}
Loading